Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure hidePrevented.bs.modal can be prevented #31696

Merged
merged 8 commits into from Sep 21, 2020

Conversation

joakimriedel
Copy link

@joakimriedel joakimriedel commented Sep 18, 2020

Fixes #31615

Copy link
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @joakimriedel 👍

Just a few modifications and it'll be good to go

js/tests/unit/modal.js Show resolved Hide resolved
js/tests/unit/modal.js Show resolved Hide resolved
@joakimriedel
Copy link
Author

Btw @Johann-S I did not commit the dist folder, assumed that is done somehow by CI?

@Johann-S
Copy link
Member

yep we build the dist folder before each release 👌

@Johann-S Johann-S added this to Inbox in v4.5.3 via automation Sep 21, 2020
@XhmikosR XhmikosR changed the title ensure hidePrevented.bs.modal can be prevented ensure hidePrevented.bs.modal can be prevented Sep 21, 2020
@XhmikosR XhmikosR merged commit b0a0c56 into twbs:v4-dev Sep 21, 2020
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.3 Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v4.5.3
Shipped
Development

Successfully merging this pull request may close these issues.

Bug in modal.js: defaultPrevented called on jQuery.Event instead of isDefaultPrevented()
3 participants