Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: Custom check shadow #31693

Merged
merged 2 commits into from Sep 18, 2020
Merged

v4: Custom check shadow #31693

merged 2 commits into from Sep 18, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Sep 17, 2020

Replaces #30762 since the remote was deleted and tests stalled out.

@arthurshlain @mdo
Update _custom-forms.scss
049152d 
Typo in box-shadow attribute, global variable used instead of local.
@mdo mdo requested a review from a team as a code owner September 17, 2020 21:33
@mdo mdo added this to Inbox in v4.5.3 via automation Sep 17, 2020
@mdo mdo mentioned this pull request Sep 17, 2020
Closed
ffoodd
ffoodd approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XhmikosR XhmikosR merged commit 7539cfb into v4-dev Sep 18, 2020
@XhmikosR XhmikosR deleted the v4-custom-check-shadow branch September 18, 2020 08:21
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.3 Sep 18, 2020
@nelsonni nelsonni mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
css v4
Projects
No open projects
v4.5.3
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdo @ffoodd @XhmikosR @arthurshlain