New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep themed appearance for checkboxes when page is printed #29714
Merged
MartijnCuppens
merged 1 commit into
master
from
master-mc-checkbox-and-radio-print-fixes
Nov 24, 2019
Merged
Keep themed appearance for checkboxes when page is printed #29714
MartijnCuppens
merged 1 commit into
master
from
master-mc-checkbox-and-radio-print-fixes
Nov 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnCuppens
changed the title
Keep themed appearance for print
Keep themed appearance for checkboxes when page is printed
Nov 22, 2019
mdo
approved these changes
Nov 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh shit what, that's awesome.
We'll need to backport this manually to |
mdo
moved this from Cherry-picked/Manually backported
to Needs manual backport
in v4.5.3
Aug 4, 2020
mdo
added a commit
that referenced
this pull request
Sep 29, 2020
Keeps checkboxes, radios, and switches with their intended design when printing. Backports #29714
Merged
mdo
moved this from Needs manual backport
to Cherry-picked/Manually backported
in v4.5.3
Sep 29, 2020
XhmikosR
pushed a commit
that referenced
this pull request
Sep 30, 2020
Keeps checkboxes, radios, and switches with their intended design when printing. Backports #29714
olsza
pushed a commit
to olsza/bootstrap
that referenced
this pull request
Oct 3, 2020
mdo
added a commit
that referenced
this pull request
Oct 4, 2020
Keeps checkboxes, radios, and switches with their intended design when printing. Backports #29714
XhmikosR
pushed a commit
that referenced
this pull request
Oct 5, 2020
Keeps checkboxes, radios, and switches with their intended design when printing. Backports #29714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: https://twbs-bootstrap.netlify.com/docs/4.3/forms/checks/
After: https://deploy-preview-29714--twbs-bootstrap.netlify.com/docs/4.3/forms/checks/
Works in Chrome, FF & Chromium Edge. The themed checkboxes don't apply to EdgeHTML & IE in
v5
, these will have the native fallback.