Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep themed appearance for checkboxes when page is printed #29714

Merged
merged 1 commit into from Nov 24, 2019

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Nov 22, 2019

Before: https://twbs-bootstrap.netlify.com/docs/4.3/forms/checks/

image

After: https://deploy-preview-29714--twbs-bootstrap.netlify.com/docs/4.3/forms/checks/

image

Works in Chrome, FF & Chromium Edge. The themed checkboxes don't apply to EdgeHTML & IE in v5, these will have the native fallback.

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner November 22, 2019 16:12
@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Nov 22, 2019
@MartijnCuppens MartijnCuppens changed the title Keep themed appearance for print Keep themed appearance for checkboxes when page is printed Nov 22, 2019
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh shit what, that's awesome.

v5 automation moved this from Inbox to Approved Nov 24, 2019
@MartijnCuppens
Copy link
Member Author

We'll need to backport this manually to v4-dev. And we'll have to find a solution for IE in v4 (I'll keep #28483 open to remind us)

@MartijnCuppens MartijnCuppens merged commit 460ba06 into master Nov 24, 2019
v5 automation moved this from Approved to Shipped Nov 24, 2019
@MartijnCuppens MartijnCuppens deleted the master-mc-checkbox-and-radio-print-fixes branch November 24, 2019 19:01
@XhmikosR XhmikosR added this to Inbox in v4.5.1 via automation May 14, 2020
@XhmikosR XhmikosR moved this from Inbox to Needs manual backport in v4.5.1 May 14, 2020
@mdo mdo added this to In progress in v4.5.3 via automation Aug 4, 2020
@mdo mdo removed this from Needs manual backport in v4.5.1 Aug 4, 2020
@mdo mdo moved this from In progress to Needs cherry-pick/Manually backported in v4.5.3 Aug 4, 2020
@mdo mdo moved this from Cherry-picked/Manually backported to Needs manual backport in v4.5.3 Aug 4, 2020
mdo added a commit that referenced this pull request Sep 29, 2020
Keeps checkboxes, radios, and switches with their intended design when printing.

Backports #29714
@mdo mdo mentioned this pull request Sep 29, 2020
@mdo mdo moved this from Needs manual backport to Cherry-picked/Manually backported in v4.5.3 Sep 29, 2020
XhmikosR pushed a commit that referenced this pull request Sep 30, 2020
Keeps checkboxes, radios, and switches with their intended design when printing.

Backports #29714
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
mdo added a commit that referenced this pull request Oct 4, 2020
Keeps checkboxes, radios, and switches with their intended design when printing.

Backports #29714
XhmikosR pushed a commit that referenced this pull request Oct 5, 2020
Keeps checkboxes, radios, and switches with their intended design when printing.

Backports #29714
@XhmikosR XhmikosR moved this from Cherry-picked/Manually backported to Shipped in v4.5.3 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v4.5.3
Shipped
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

2 participants