GCS: fix error handling when checking for bucket existence (#299)

angelsk · web-flow · commit 9eeb26c40042 · 2022-09-30T22:15:39.000+02:00
diff --git a/lib/stores/GCSDataStore.js b/lib/stores/GCSDataStore.js
@@ -46,7 +46,7 @@ class GCSDataStore extends DataStore {
         const bucket = this.gcs.bucket(this.bucket_name);
         bucket.exists((error, exists) => {
             // ignore insufficient access error, assume bucket exists
-            if (error.code === 403) {
+            if (error && error.code === 403) {
                 return;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ class GCSDataStore extends DataStore {`
`46`	`46`	`const bucket = this.gcs.bucket(this.bucket_name);`
`47`	`47`	`bucket.exists((error, exists) => {`
`48`	`48`	`// ignore insufficient access error, assume bucket exists`
`49`		`- if (error.code === 403) {`
	`49`	`+ if (error && error.code === 403) {`
`50`	`50`	`return;`
`51`	`51`	`}`
`52`	`52`