Emit upload complete event when using creation-with-upload extension (#301)

Author: mitjap

lib/handlers/PatchHandler.js

@@ -63,7 +63,7 @@ class PatchHandler extends BaseHandler {
         }
 
         const new_offset = await this.store.write(req, file_id, offset);
-        if (parseInt(new_offset, 10) === parseInt(upload_length, 10)) {
+        if (new_offset === parseInt(upload_length, 10)) {
             this.emit(EVENTS.EVENT_UPLOAD_COMPLETE, { file: new File(file_id, file.upload_length, file.upload_defer_length, file.upload_metadata) });
         }
 

lib/handlers/PostHandler.js

@@ -65,6 +65,10 @@ class PostHandler extends BaseHandler {
         if (!RequestValidator.isInvalidHeader('content-type', req.headers['content-type'])) {
             const new_offset = await this.store.write(req, file.id, 0);
             optional_headers['Upload-Offset'] = new_offset;
+
+            if (new_offset === parseInt(upload_length, 10)) {
+                this.emit(EVENTS.EVENT_UPLOAD_COMPLETE, { file: new File(file_id, file.upload_length, file.upload_defer_length, file.upload_metadata) });
+            }
         }
 
         return this.write(res, 201, { Location: url, ...optional_headers });

test/Test-PostHandler.js

@@ -144,6 +144,42 @@ describe('PostHandler', () => {
                 req.headers = { 'upload-length': 1000, host: 'localhost:3000' };
                 handler.send(req, res);
             })
+
+            it(`must fire the ${EVENTS.EVENT_UPLOAD_COMPLETE} event when upload is complete with single request`, (done) => {
+                const fake_store = sinon.createStubInstance(DataStore);
+
+                const upload_length = 1000;
+                
+                fake_store.create.resolvesArg(0);
+                fake_store.write.resolves(upload_length);
+
+                const handler = new PostHandler(fake_store, { path: '/test/output' });
+                handler.on(EVENTS.EVENT_UPLOAD_COMPLETE, (obj) => {
+                    done();
+                });
+
+                req.headers = { 'upload-length': `${upload_length}`, host: 'localhost:3000', 'content-type': 'application/offset+octet-stream' };
+                handler.send(req, res);
+            })
+
+            it(`must not fire the ${EVENTS.EVENT_UPLOAD_COMPLETE} event when upload-length is defered`, (done) => {
+                const fake_store = sinon.createStubInstance(DataStore);
+
+                const upload_length = 1000;
+                
+                fake_store.create.resolvesArg(0);
+                fake_store.write.resolves(upload_length);
+
+                const handler = new PostHandler(fake_store, { path: '/test/output' });
+                handler.on(EVENTS.EVENT_UPLOAD_COMPLETE, (obj) => {
+                    done(new Error());
+                });
+
+                req.headers = { 'upload-defer-length': '1', host: 'localhost:3000', 'content-type': 'application/offset+octet-stream' };
+                handler.send(req, res)
+                .then(() => done())
+                .catch(done);
+            })
         });
     });
 });