Remove enforcing the use of types

Author: SamVerschueren

source/lib/rules/types-property.ts

@@ -12,16 +12,6 @@ import {getJSONPropertyPosition} from '../utils';
 export default (context: Context): Diagnostic[] => {
 	const {pkg} = context;
 
-	if (!pkg.types && !pkg.typings) {
-		return [
-			{
-				fileName: 'package.json',
-				message: 'Can\'t find `types` property.',
-				severity: 'error'
-			}
-		];
-	}
-
 	if (!pkg.types && pkg.typings) {
 		const content = fs.readFileSync(path.join(context.cwd, 'package.json'), 'utf8');
 

source/test/fixtures/expect-error/functions/package.json

@@ -1,4 +1,3 @@
 {
-	"name": "foo",
-	"types": "index.d.ts"
+	"name": "foo"
 }

source/test/fixtures/expect-error/syntax/package.json

@@ -1,4 +1,3 @@
 {
-	"name": "foo",
-	"types": "index.d.ts"
+	"name": "foo"
 }

source/test/fixtures/expect-error/values/package.json

@@ -1,4 +1,3 @@
 {
-	"name": "foo",
-	"types": "index.d.ts"
+	"name": "foo"
 }

source/test/fixtures/failure-nested/package.json

@@ -1,4 +1,3 @@
 {
-	"name": "foo",
-	"types": "index.d.ts"
+	"name": "foo"
 }

source/test/fixtures/failure-strict-null-checks/package.json

@@ -1,4 +1,3 @@
 {
-	"name": "foo",
-	"types": "index.d.ts"
+	"name": "foo"
 }

source/test/fixtures/failure/package.json

@@ -1,4 +1,3 @@
 {
-	"name": "foo",
-	"types": "index.d.ts"
+	"name": "foo"
 }

source/test/fixtures/no-files/package.json

@@ -1,6 +1,5 @@
 {
 	"name": "foo",
-	"types": "index.d.ts",
 	"files": [
 		"index.js"
 	]

source/test/fixtures/no-test/package.json

@@ -1,4 +1,3 @@
 {
-	"name": "foo",
-	"types": "index.d.ts"
+	"name": "foo"
 }

source/test/fixtures/non-strict-check-with-config/package.json

@@ -1,6 +1,5 @@
 {
 	"name": "foo",
-	"types": "index.d.ts",
 	"tsd-check": {
 		"compilerOptions": {
 			"strict": false

source/test/fixtures/success/package.json

@@ -1,6 +1,5 @@
 {
 	"name": "foo",
-	"types": "index.d.ts",
 	"files": [
 		"index.js",
 		"index.d.ts"

source/test/fixtures/test-directory/custom/package.json

@@ -0,0 +1,6 @@
+{
+	"name": "foo",
+	"tsd-check": {
+		"directory": "test"
+	}
+}

source/test/fixtures/top-level-await/package.json

@@ -1,6 +1,5 @@
 {
 	"name": "foo",
-	"types": "index.d.ts",
 	"files": [
 		"index.js",
 		"index.d.ts"

source/test/test.ts

@@ -37,25 +37,13 @@ test('fail if typings file is not part of `files` list', async t => {
 			fileName: 'package.json',
 			message: 'TypeScript type definition `index.d.ts` is not part of the `files` list.',
 			severity: 'error',
-			line: 4,
+			line: 3,
 			column: 1
 		}
 	]);
 });
 
-test('fail if `types` property is not set', async t => {
-	const diagnostics = await m({cwd: path.join(__dirname, 'fixtures/types-property/no-property')});
-
-	t.deepEqual(diagnostics, [
-		{
-			fileName: 'package.json',
-			message: 'Can\'t find `types` property.',
-			severity: 'error'
-		}
-	]);
-});
-
-test('fail if `typings` property is is used instead of `types`', async t => {
+test('fail if `typings` property is used instead of `types`', async t => {
 	const diagnostics = await m({cwd: path.join(__dirname, 'fixtures/types-property/typings')});
 
 	t.deepEqual(diagnostics, [