Skip to content

Commit b66571f

Browse files
committedMar 6, 2017
formatting
1 parent a778ea5 commit b66571f

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed
 

‎TODO.md

+6
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@
77
# changes to ctor and log.child to separate fields from config
88

99
Current:
10+
1011
createLogger(<config-and-fields>)
1112
log.child(<config-and-fields>, <just-fields-bool>)
1213

1314
Could be:
15+
1416
createLogger(<config-and-fields>, <fields>)
1517
log.child(<config-and-fields>, <fields>)
1618
# Still support: log.child(<config-and-fields>, <just-fields-bool>)
@@ -19,11 +21,15 @@ Pros: Compat issues are minimal: a change is only required if there is a
1921
collision with used field and a new config var name.
2022
Cons: A *slight* con is that my guess is the common usage of child is
2123
`log.child(<fields>)`, so the more future-proof common usage becomes:
24+
2225
log.child(null, <fields>)
26+
2327
That's not too bad. It is clearer at least than:
28+
2429
log.child(<fields>, true)
2530

2631
TODO:
32+
2733
- is there a ticket for this work already?
2834
- make the change
2935
- do a migration guide? i.e. provide the grep commands to find all

0 commit comments

Comments
 (0)
Please sign in to comment.