File tree 1 file changed +6
-0
lines changed
1 file changed +6
-0
lines changed Original file line number Diff line number Diff line change 7
7
# changes to ctor and log.child to separate fields from config
8
8
9
9
Current:
10
+
10
11
createLogger(<config-and-fields>)
11
12
log.child(<config-and-fields>, <just-fields-bool>)
12
13
13
14
Could be:
15
+
14
16
createLogger(<config-and-fields>, <fields>)
15
17
log.child(<config-and-fields>, <fields>)
16
18
# Still support: log.child(<config-and-fields>, <just-fields-bool>)
@@ -19,11 +21,15 @@ Pros: Compat issues are minimal: a change is only required if there is a
19
21
collision with used field and a new config var name.
20
22
Cons: A * slight* con is that my guess is the common usage of child is
21
23
` log.child(<fields>) ` , so the more future-proof common usage becomes:
24
+
22
25
log.child(null, <fields>)
26
+
23
27
That's not too bad. It is clearer at least than:
28
+
24
29
log.child(<fields>, true)
25
30
26
31
TODO:
32
+
27
33
- is there a ticket for this work already?
28
34
- make the change
29
35
- do a migration guide? i.e. provide the grep commands to find all
You can’t perform that action at this time.
0 commit comments