Skip to content

Commit a778ea5

Browse files
committedMar 4, 2017
TODO notes for change to allow new config fields
1 parent 4d46637 commit a778ea5

File tree

1 file changed

+34
-2
lines changed

1 file changed

+34
-2
lines changed
 

‎TODO.md

+34-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,37 @@
1+
# higher prio
2+
13
- `bunyan` (without redir) ^C should stop, doesn't since recent change
24
- man page for the bunyan CLI (refer to it in the readme)
3-
- `tail -f`-like support
4-
- 2.0 (?) with `v: 1` in log records. Fwd/bwd compat in `bunyan` CLI
5+
6+
7+
# changes to ctor and log.child to separate fields from config
8+
9+
Current:
10+
createLogger(<config-and-fields>)
11+
log.child(<config-and-fields>, <just-fields-bool>)
12+
13+
Could be:
14+
createLogger(<config-and-fields>, <fields>)
15+
log.child(<config-and-fields>, <fields>)
16+
# Still support: log.child(<config-and-fields>, <just-fields-bool>)
17+
18+
Pros: Compat issues are minimal: a change is only required if there is a
19+
collision with used field and a new config var name.
20+
Cons: A *slight* con is that my guess is the common usage of child is
21+
`log.child(<fields>)`, so the more future-proof common usage becomes:
22+
log.child(null, <fields>)
23+
That's not too bad. It is clearer at least than:
24+
log.child(<fields>, true)
25+
26+
TODO:
27+
- is there a ticket for this work already?
28+
- make the change
29+
- do a migration guide? i.e. provide the grep commands to find all
30+
possible calls to inspect. E.g. if don't have `rg logUndefined` in your
31+
code, then you are fine. And one time future-proofing via changing
32+
to fields in the *second* arg.
33+
- list of issues/pulls that wanted to add new config fields
34+
535

636
# docs
737

@@ -10,6 +40,8 @@
1040

1141
# someday/maybe
1242

43+
- 2.0 (?) with `v: 1` in log records. Fwd/bwd compat in `bunyan` CLI
44+
- `tail -f`-like support
1345
- full-on docs
1446
- better examples/
1547
- better coloring

0 commit comments

Comments
 (0)
Please sign in to comment.