Skip to content

Commit

Permalink
fix 'make check'; version 1.8.7
Browse files Browse the repository at this point in the history
  • Loading branch information
trentm committed Mar 3, 2017
1 parent 55f8c9d commit 907489d
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
7 changes: 7 additions & 0 deletions CHANGES.md
Expand Up @@ -8,8 +8,15 @@ Known issues:
## not yet released


## 1.8.7

- [issue #484] Fix breakage due to #474 in previous release.


## 1.8.6

Note: *Bad release.* Use 1.8.7 or later.

- [issue #474] Bunyan's `safeCycles` is too slow when logging large objects.


Expand Down
2 changes: 1 addition & 1 deletion bin/bunyan
Expand Up @@ -11,7 +11,7 @@
* vim: expandtab:ts=4:sw=4
*/

var VERSION = '1.8.6';
var VERSION = '1.8.7';

var p = console.log;
var util = require('util');
Expand Down
4 changes: 2 additions & 2 deletions lib/bunyan.js
Expand Up @@ -8,7 +8,7 @@
* vim: expandtab:ts=4:sw=4
*/

var VERSION = '1.8.6';
var VERSION = '1.8.7';

/*
* Bunyan log format version. This becomes the 'v' field on all log records.
Expand Down Expand Up @@ -1197,7 +1197,7 @@ function safeCyclesArray() {
* Choose the best safe cycle function from what is available - see
* trentm/node-bunyan#445.
*/
var safeCycles = typeof Set !== 'undefined' ? safeCyclesSet : safeCyclesArray;
var safeCycles = typeof (Set !== 'undefined') ? safeCyclesSet : safeCyclesArray;

/**
* A fast JSON.stringify that handles cycles and getter exceptions (when
Expand Down
2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "bunyan",
"version": "1.8.6",
"version": "1.8.7",
"description": "a JSON logging library for node.js services",
"author": "Trent Mick <trentm@gmail.com> (http://trentm.com)",
"main": "./lib/bunyan.js",
Expand Down

2 comments on commit 907489d

@Nathan219
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still resulting in

ar safeCycles = typeof (Set !== 'undefined') ? safeCyclesSet : safeCyclesArra
                         ^
ReferenceError: Set is not defined

@trentm
Copy link
Owner Author

@trentm trentm commented on 907489d Mar 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nathan219 Yah, thanks. Discussing in #484

Please sign in to comment.