feat: allow setting a custom iframe title #317
Merged
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fd64463:
|
ruisaraiva19
requested changes
Jan 4, 2022
ruisaraiva19
requested changes
Jan 4, 2022
ruisaraiva19
approved these changes
Jan 4, 2022
|
@pcorpet please update your last commit message to follow the conventional commits guidelines. |
|
@ruisaraiva19 are you OK if I merge the two commits (with the initial message) and hard push them on the branch? |
This allows for a better accessibility especially for screen readers. See https://www.w3.org/TR/WCAG20-TECHS/H64.html.
|
I would need to force push anyway to drop the second commit, so I'm going to do it. |
|
🎉 This PR is included in version 7.14.0-canary.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 7.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for a better accessibility especially for screen readers.
See https://www.w3.org/TR/WCAG20-TECHS/H64.html.