Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lazy load #308

Merged
merged 2 commits into from
Aug 19, 2021
Merged

feat: lazy load #308

merged 2 commits into from
Aug 19, 2021

Conversation

Foo-x
Copy link
Contributor

@Foo-x Foo-x commented Aug 18, 2021

Refs #234

image
lazy-load

I wish it would be released if merged.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 18, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 25eee0e:

Sandbox Source
Vanilla Configuration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Foo-x
Copy link
Contributor Author

Foo-x commented Aug 19, 2021

Thank you for your review!
Since auto is the Chromium specific value, I think that the default value should be null to let the browser decide.
It will be auto on Chromium and eager on the others.
What do you think?

I've pushed with the above.

@Foo-x Foo-x requested a review from ruisaraiva19 August 19, 2021 01:09
@ruisaraiva19 ruisaraiva19 merged commit 32d55c7 into tjallingt:canary Aug 19, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.14.0-canary.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Foo-x Foo-x deleted the lazy-load branch August 19, 2021 07:31
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

🎉 This PR is included in version 7.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants