-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: shouldResetPlayer options spread #284
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c8beb15:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
@staff0rd can you sync your fork with the latest changes from this repo before I can merge this? |
🎉 This PR is included in version 7.13.1-canary.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 7.13.2-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 7.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@staff0rd Do you still know why you added |
Reset is currently broken, mostly due to the position of the
playerVars
spread. I also added a test to prove this.Prior to this fix, any change to
start
was still resulting in a player reset.