-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevents reset when only dimensions change #278
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d4fe8cc:
|
@tjallingt This looks good to me. Please take a look and let me know if I can merge it 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks 😊
🎉 This PR is included in version 7.13.1-canary.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 7.13.2-canary.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 7.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi! Didn't find any info about that in release changelog. |
height
andwidth
are given fixed values infilterResetOptions()
to prevent changes to these from causing a reset.Changes to these could trigger a classname change
height
andwidth
are set inupdatePlayer()
if they were provided.Closes #247