Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevents reset when only dimensions change #278

Merged
merged 2 commits into from
Mar 13, 2021

Conversation

dancancro
Copy link
Contributor

height and width are given fixed values in filterResetOptions() to prevent changes to these from causing a reset.

Changes to these could trigger a classname change

height and width are set in updatePlayer() if they were provided.

Closes #247

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 24, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d4fe8cc:

Sandbox Source
Vanilla Configuration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ruisaraiva19 ruisaraiva19 changed the title Prevents reset when only dimensions change fix: prevents reset when only dimensions change Mar 13, 2021
@ruisaraiva19
Copy link
Collaborator

@tjallingt This looks good to me. Please take a look and let me know if I can merge it 🙂

Copy link
Owner

@tjallingt tjallingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks 😊

@ruisaraiva19 ruisaraiva19 merged commit d5f7908 into tjallingt:canary Mar 13, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.13.1-canary.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.13.2-canary.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

🎉 This PR is included in version 7.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zarv1k
Copy link

zarv1k commented Mar 28, 2022

Hi!
@dancancro this PR introduces the breaking change:
In 7.13.1 if there were no size opts provided explicitly the default iframe size (WxH) was 640x360.
In 7.14.0 if there are no size opts provided explicitly width and height attributes on iframe are removed.

Didn't find any info about that in release changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does the player reset when only the dimensions have changed?
4 participants