-
Notifications
You must be signed in to change notification settings - Fork 67
Use a geometric shape for the menu symbol (rather than the Taoist Bagua trigram for Heaven) #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why does it seem wrong? The ☰ icon is a very widely used icon to indicate a menu, and the origin of a glyph is only relevant if people think of that when they see it, and are confused or offended. Is either of those a concrete complaint here? |
It's at least poor form to (ab)use a code point because the associated glyph has convenient characteristics, and generally troublesome for people using a screen reader (although I do not know for certain that such is the case here). Unicode is clear about "character" corresponding with abstract meaning rather than shape. |
I agree the current thing is an abuse of Unicode, though I think it's kind of a shame they haven't officially blessed this usage (or given "hamburger menu" its own code point). Concretely, I'd be happier with an SVG or faking it with CSS rather than
or as a data URI:
|
I was reminded of this by the ecmarkup preview in Matrix. Should it land using U+25A4 SQUARE WITH HORIZONTAL FILL, or switch to SVG? And either way, I'm now also thinking about a followup that leverages ARIA like https://www.w3.org/TR/wai-aria-practices/#menu and/or https://til.simonwillison.net/javascript/dropdown-menu-with-details-summary . |
Let's use an SVG. I'm fine with the one I suggested above if you don't want to come up with a new one, but I'm not attached to it if you have something you'd prefer. Re: ARAI, there's definitely room for improvement, and I'd be happy to review such a PR (though I currently lack the knowledge to write one). |
07c8744
to
c1baeb4
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the stroke
thing. Thanks for following up, and sorry for letting this sit so long.
Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
Not at all, the fault was mine. |
…ua trigram for Heaven) (#265)
I'm a little on the fence about this one, but it seems wrong to use U+2630 TRIGRAM FOR HEAVEN for representing a menu because the glyph happens to look approximately as desired. This geometric symbol (U+25A4 SQUARE WITH HORIZONTAL FILL) is the best substitute I could find in Unicode, but alternatively we could just use an SVG.