adds 'diagnostic' flag to include diags always

Passing tests typically don't get a yaml diagnostic block.

With this, you can pass `diagnostic:true` to include a yaml block
regardless of whether the test is a pass or fail.

Fix #243

Author: isaacs

lib/test.js

@@ -1350,7 +1350,7 @@ Test.prototype.printResult = function printResult (ok, message, extra) {
   this.push('\n')
 
   // If we're skipping, no need for diags.
-  if (!ok && !extra.skip) {
+  if (!ok && !extra.skip || extra.diagnostic) {
     this.writeDiags(extra)
   }
 
@@ -1377,6 +1377,7 @@ function yamlFilter (propertyName, isRoot, source, target) {
 
   return !(propertyName === 'todo' ||
   propertyName === 'skip' ||
+  propertyName === 'diagnostic' ||
   (propertyName === 'at' && !source[propertyName]))
 }
 

test/test/ok-diags-bail.tap

@@ -0,0 +1,16 @@
+TAP version 13
+ok 1 - this is fine
+  ---
+  {"foo":{"bar":"baz"}}
+  ...
+    # Subtest: child
+    1..1
+    ok 1 - this is fine
+ok 2 - child ___/# time=[0-9.]+(ms)?/~~~
+  ---
+  {"at":{"column":3,"file":"test/test/ok-diags.js","line":10},"results":{"count":1,"ok":true,"pass":1,"plan":{"end":1,"start":1}},"source":"t.test('child', { diagnostic: true }, function (t) {\n"}
+  ...
+
+1..2
+___/# time=[0-9.]+(ms)?/~~~
+

test/test/ok-diags.js

@@ -0,0 +1,13 @@
+var t = require('../..')
+
+t.pass('this is fine',{
+  diagnostic: true,
+  foo: {
+    bar: 'baz'
+  }
+})
+
+t.test('child', { diagnostic: true }, function (t) {
+  t.plan(1)
+  t.pass('this is fine')
+})

test/test/ok-diags.tap

@@ -0,0 +1,16 @@
+TAP version 13
+ok 1 - this is fine
+  ---
+  {"foo":{"bar":"baz"}}
+  ...
+    # Subtest: child
+    1..1
+    ok 1 - this is fine
+ok 2 - child ___/# time=[0-9.]+(ms)?/~~~
+  ---
+  {"at":{"column":3,"file":"test/test/ok-diags.js","line":10},"results":{"count":1,"ok":true,"pass":1,"plan":{"end":1,"start":1}},"source":"t.test('child', { diagnostic: true }, function (t) {\n"}
+  ...
+
+1..2
+___/# time=[0-9.]+(ms)?/~~~
+