gracefully handle the lack of a global.process object

Author: isaacs

lib/repl.js

@@ -1,3 +1,8 @@
+const nodeProcess = typeof process === 'object' && process ? process : {
+  stdin: null,
+  stdout: null,
+  env: {},
+}
 const {Watch} = require('./watch.js')
 const repl = require('repl')
 const rimraf = require('rimraf').sync
@@ -6,12 +11,18 @@ const path = require('path')
 const fs = require('fs')
 /* istanbul ignore next */
 const noop = () => {}
+const {isStream} = require('minipass')
 
 // XXX useGlobal = true, because it doesn't matter, so save the cycles
 class Repl {
   constructor (options, input, output) {
-    this.output = output || /* istanbul ignore next */ process.stdout
-    this.input = input || /* istanbul ignore next */ process.stdin
+    this.output = output || nodeProcess.stdout
+    if (!isStream(this.output))
+      throw new Error('output stream not provided, stdout unavailable')
+
+    this.input = input || nodeProcess.stdin
+    if (!isStream(this.input))
+      throw new Error('input stream not provided, stdin unavailable')
 
     this.repl = null
     this._cb = null
@@ -50,7 +61,7 @@ class Repl {
   }
 
   loadHistory () {
-    const dir = process.env.HOME || 'node_modules/.cache/tap'
+    const dir = nodeProcess.env.HOME || 'node_modules/.cache/tap'
 
     try {
       return fs.readFileSync(dir + '/.tap_repl_history', 'utf8')
@@ -61,7 +72,7 @@ class Repl {
   }
 
   saveHistory () {
-    const dir = process.env.HOME || 'node_modules/.cache/tap'
+    const dir = nodeProcess.env.HOME || 'node_modules/.cache/tap'
 
     require('../settings.js').mkdirRecursiveSync(dir)
     try {

lib/watch.js

@@ -1,3 +1,5 @@
+const proc = typeof process === 'object' && process ? process : null
+
 const chokidar = require('chokidar')
 const EE = require('events')
 const Minipass = require('minipass')
@@ -12,25 +14,27 @@ class Watch extends Minipass {
   constructor (options) {
     if (!options.coverage)
       throw new Error('--watch requires coverage to be enabled')
+    if (!proc)
+      throw new Error('--watch requires working node.js process object')
     super()
     this.args = [bin, ...options._.parsed, '--no-watch']
     this.positionals = [...options._]
     this.log('initial test run', this.args)
-    this.proc = spawn(process.execPath, this.args, {
+    this.proc = spawn(proc.execPath, this.args, {
       stdio: 'inherit'
     })
     this.proc.on('close', () => this.main())
     const saveFolder = 'node_modules/.cache/tap'
     require('../settings.js').mkdirRecursiveSync(saveFolder)
-    this.saveFile = saveFolder + '/watch-' + process.pid
+    this.saveFile = saveFolder + '/watch-' + proc.pid
     /* istanbul ignore next */
     onExit(() => require('../settings.js').rmdirRecursiveSync(this.saveFile))
     this.index = null
     this.indexFile = '.nyc_output/processinfo/index.json'
     this.fileList = []
     this.queue = []
     this.watcher = null
-    this.env = { ...process.env }
+    this.env = { ...proc.env }
   }
 
   readIndex () {
@@ -51,7 +55,7 @@ class Watch extends Minipass {
     // Since a covered test was definitely included in its own
     // test run, don't add it a second time, so we don't get
     // two chokidar events for the same file change.
-    const cwd = process.cwd()
+    const cwd = proc.cwd()
     const fileSet = new Set(Object.keys(this.index.files))
     Object.keys(this.index.externalIds)
       .filter(f => !fileSet.has(resolve(f)))
@@ -109,7 +113,7 @@ class Watch extends Minipass {
     writeFileSync(this.saveFile, set.join('\n') + '\n')
     this.queue.length = 0
 
-    this.proc = spawn(process.execPath, [
+    this.proc = spawn(proc.execPath, [
       ...this.args, '--save=' + this.saveFile, '--nyc-arg=--no-clean'
     ], {
       stdio: 'inherit',

test/repl.js

@@ -240,3 +240,17 @@ t.test('exit', t => {
   t.matchSnapshot(output.read(), 'output')
   t.end()
 })
+
+t.test('throw if input/output not a stream', t => {
+  const proc = process
+  global.process = null
+  t.teardown(() => global.process = proc)
+  const {Repl} = t.mock('../lib/repl.js')
+  t.throws(() => new Repl({}, input, null), {
+    message: 'output stream not provided, stdout unavailable',
+  })
+  t.throws(() => new Repl({}, null, output), {
+    message: 'input stream not provided, stdin unavailable',
+  })
+  t.end()
+})

test/watch.js

@@ -157,6 +157,17 @@ t.throws(() => new Watch({}), {
   message: '--watch requires coverage to be enabled'
 })
 
+t.test('not available when no node process', t => {
+  const proc = process
+  global.process = null
+  t.teardown(() => global.process = proc)
+  const {Watch} = t.mock('../lib/watch.js')
+  t.throws(() => new Watch({ coverage: true }), {
+    message: '--watch requires working node.js process object',
+  })
+  t.end()
+})
+
 t.test('run tests on changes', t => {
   t.test('initial test', t => {
     spawnTrack.once('spawn', proc => {