Fail unfinished tests

Closes #129

If a test does not have a .end() (or a plan that would do the same)
then emit a test failure.

Note: this used to work in tap 0.x, though only by mistake.  In tap
1.x, it started silently ignoring the un-run tests but otherwise
passing, which is a TERRIBLE way to behave.

Author: isaacs

lib/test.js

@@ -136,12 +136,17 @@ Test.prototype.endAll = function () {
   var child = this._currentChild
   if (child) {
     child._queue = []
+    if (!child._ended && !child._plan) {
+      child.fail('test left unfinished: no end(), no plan()', {
+        at: this._calledAt
+      })
+    }
+    if (child.end)
+      child.end()
     if (child.endAll)
       child.endAll()
     if (child.kill)
       child.kill('SIGKILL')
-    if (child.end)
-      child.end()
     child._bailedOut = true
   }
 

test/test/ok.js

@@ -1,4 +1,4 @@
-var t = require('../../lib/test.js')()
+var t = require('../..')
 
 t.test('nesting', function (t) {
   t.plan(2)
@@ -38,7 +38,3 @@ t.test('async kid', function (t) {
 })
 
 t.pass('pass after async kid')
-
-t.end()
-
-t.pipe(process.stdout)

test/test/unfinished.js

@@ -0,0 +1,16 @@
+var tap = require('../..')
+
+tap.test('parent', function(t) {
+  t.test('child 1', function(t) {
+    t.test('grandchild 1', function(t) {
+      t.pass('1')
+      t.end()
+    })
+  })
+  t.test('child 2', function(t) {
+    t.test('grandchild 2', function(t) {
+      t.pass('2')
+      t.end()
+    })
+  })
+})

test/test/unfinished.tap

@@ -0,0 +1,17 @@
+TAP version 13
+    # Subtest: parent
+        # Subtest: child 1
+            # Subtest: grandchild 1
+            ok 1 - 1
+            1..1
+        ok 1 - grandchild 1 ___/# time=[0-9.]+(ms)?/~~~
+
+        1..1
+    ok 1 - child 1 ___/# time=[0-9.]+(ms)?/~~~
+
+    1..1
+ok 1 - parent ___/# time=[0-9.]+(ms)?/~~~
+
+1..1
+___/# time=[0-9.]+(ms)?/~~~
+