New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: highlight code scroll console error (#7497) #7519
Merged
char0n
merged 9 commits into
swagger-api:master
from
kristina-kovacikova:bug/7497-console-error-on-scroll
Oct 5, 2021
Merged
fix: highlight code scroll console error (#7497) #7519
char0n
merged 9 commits into
swagger-api:master
from
kristina-kovacikova:bug/7497-console-error-on-scroll
Oct 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kristina-kovacikova thank you for the PR. Can you please remove modified |
…m/kristina-kovacikova/swagger-ui into bug/7497-console-error-on-scroll
char0n
reviewed
Sep 29, 2021
mathis-m
suggested changes
Oct 4, 2021
shorten the code Co-authored-by: Mahtis Michel <mathis.michel@outlook.de>
shorten the code Co-authored-by: Mahtis Michel <mathis.michel@outlook.de>
@mathis-m tested and committed your suggestions, thanks |
char0n
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thank you for contributing.
please build |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
touch-action: none
did not fix the issueMotivation and Context
Fixes #7497
How Has This Been Tested?
swagger-ui
and runnpm run dev
wait a while and openlocalhost:3200
PUT /pets
endpointcode
element within div with class "highlight-code"code
element as HTML and duplicate it => as a result the example body will be longer and scrollableconsole in devtools
and scroll example body all the way till the whole page starts scrolling => there should be no errors in the consoleScreenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests