fix: curlify agnostic to order of header values #6152
Merged
+76
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char0n
requested changes
Jun 17, 2020
tim-lai
force-pushed
the
bug/6082-requestInterceptor
branch
from
5ebe258 to
f35501e
Compare
tim-lai
changed the title
tim-lai
force-pushed
the
bug/6082-requestInterceptor
branch
from
f35501e to
33705ff
Compare
|
@char0n Updated. Please take another look. Thanks! |
char0n
reviewed
Jun 18, 2020
char0n
reviewed
Jun 18, 2020
char0n
reviewed
Jun 18, 2020
char0n
reviewed
Jun 18, 2020
Refs swagger-api#6082 * use curlify flag isMultipartFormDataRequest * curlify test updated
tim-lai
force-pushed
the
bug/6082-requestInterceptor
branch
from
33705ff to
7a22752
Compare
char0n
approved these changes
Jun 18, 2020
Co-authored-by: Vladimir Gorej <vladimir.gorej@gmail.com>
Co-authored-by: Vladimir Gorej <vladimir.gorej@gmail.com>
Co-authored-by: Vladimir Gorej <vladimir.gorej@gmail.com>
mattyb678
pushed a commit
to mattyb678/swagger-ui
that referenced
this pull request
Jun 24, 2020
Refs swagger-api#6082 * use curlify flag isMultipartFormDataRequest * curlify test updated Co-authored-by: Vladimir Gorej <vladimir.gorej@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
curlify, thetypewould overwrite the string value to the latest header value. In the case of usingrequestInterceptorthat appends a header, the final string would be whatever was provided by therequestInterceptor.This fix will try to update
isMultipartFormDataRequestuntil it istrue.This change also reorganizes and fixes the linting in the
curlifytest fileMotivation and Context
Fixes #6082
How Has This Been Tested?
New mocha tests that places leading/trailing custom header. There already exists a mocha test with no custom header. Note, although the term
customis used, any header and order should not impact the curlify result.Screenshots (if appropriate):
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests