Skip to content

Commit 3329f5b

Browse files
authoredNov 27, 2021
deps: remove semver and mkdirp deps and add node17 test (#2641)
* deps: remove semver and mkdirp deps * ci: add node v17 test * ci: change ci yml config * ci: fix yml grammer error * [skip ci] use matrix os
1 parent e64ae7d commit 3329f5b

File tree

5 files changed

+24
-22
lines changed

5 files changed

+24
-22
lines changed
 

‎.github/workflows/ci.yml

+22-6
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,10 @@ on:
1010

1111
jobs:
1212
node_tests:
13-
name: 'Test stylus on ${{matrix.os}} with node${{matrix.node}}'
13+
name: 'Test stylus on ${{matrix.os}} with node16'
1414
strategy:
1515
matrix:
1616
os: [ubuntu-latest, macos-latest, windows-latest]
17-
# Latest four Nodejs LTS version
18-
node: [10, 12, 14, 16]
1917
runs-on: ${{ matrix.os }}
2018
steps:
2119
# Pull repo to test machine
@@ -24,7 +22,7 @@ jobs:
2422
- uses: actions/setup-node@v2
2523
with:
2624
# The Node.js version to configure
27-
node-version: ${{ matrix.node }}
25+
node-version: '16'
2826
# Caching dependencies to speed up workflows
2927
- name: Get npm cache directory
3028
id: npm-cache-dir
@@ -43,8 +41,26 @@ jobs:
4341
# Output useful info for debugging.
4442
run: node --version && npm --version
4543
- name: Run Test
46-
run: npm run test
47-
44+
run: npm run test
4845
# Not work currently, need investigate
4946
#- name: Run Test Cov
5047
# run: npm run test-cov
48+
49+
compat_node_tests:
50+
name: 'Compat test stylus on ${{matrix.os}} with node${{matrix.node}}'
51+
strategy:
52+
matrix:
53+
os: [ubuntu-latest]
54+
node: [10, 12, 14, 17]
55+
runs-on: ${{ matrix.os }}
56+
steps:
57+
- uses: actions/checkout@v2
58+
- uses: actions/setup-node@v2
59+
with:
60+
node-version: ${{ matrix.node }}
61+
- name: Install npm dependencies
62+
run: npm install
63+
- name: Print put node & npm version
64+
run: node --version && npm --version
65+
- name: Run Test
66+
run: npm run test

‎bin/stylus

+1-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ var fs = require('fs')
1212
, resolve = require('path').resolve
1313
, join = require('path').join
1414
, isWindows = process.platform === 'win32'
15-
, semver = require('semver')
16-
, mkdirSync = semver.satisfies(process.version, '>=10.12.0') ? fs.mkdirSync : require('mkdirp').sync;
15+
, mkdirSync = fs.mkdirSync;
1716

1817
/**
1918
* Arguments.

‎lib/middleware.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,13 @@
99
*/
1010

1111
var stylus = require('./stylus')
12-
, semver = require('semver')
1312
, fs = require('fs')
1413
, url = require('url')
1514
, dirname = require('path').dirname
1615
, join = require('path').join
1716
, sep = require('path').sep
1817
, debug = require('debug')('stylus:middleware')
19-
, mkdir = semver.satisfies(process.version, '>=10.12.0') ? fs.mkdir : require('mkdirp');
18+
, mkdir = fs.mkdir;
2019

2120
/**
2221
* Import map.

‎package-lock.json

-10
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

-2
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,8 @@
3232
"css": "^3.0.0",
3333
"debug": "^4.3.2",
3434
"glob": "^7.1.6",
35-
"mkdirp": "~1.0.4",
3635
"safer-buffer": "^2.1.2",
3736
"sax": "~1.2.4",
38-
"semver": "^6.3.0",
3937
"source-map": "^0.7.3"
4038
},
4139
"devDependencies": {

0 commit comments

Comments
 (0)
Please sign in to comment.