Fix: Fix duplicated components with default glob on windows (#1128)

Closes #1127

Author: elevatebart

loaders/utils/getComponentFiles.js

@@ -3,12 +3,32 @@ const glob = require('glob');
 const isFunction = require('lodash/isFunction');
 const isString = require('lodash/isString');
 
+const getComponentGlobs = components => {
+	if (isFunction(components)) {
+		return components();
+	} else if (Array.isArray(components)) {
+		return components;
+	} else if (isString(components)) {
+		return [components];
+	}
+	throw new Error(
+		`Styleguidist: components should be string, function or array, received ${typeof components}.`
+	);
+};
+
 const getFilesMatchingGlobs = (components, rootDir, ignore) =>
 	components
 		.map(listItem => {
 			// Check if the string looks like a glob pattern by using hasMagic
 			if (glob.hasMagic(listItem)) {
-				return glob.sync(path.resolve(rootDir, listItem), { ignore });
+				return glob.sync(listItem, {
+					cwd: rootDir,
+					ignore,
+					// in order to avoid detecting each component twice on windows
+					// when matching 2 cases of the same word, like {Src,src}
+					// we remove case-sensitivity on windows
+					nocase: process.platform === 'win32',
+				});
 			}
 			// Wrap path in an array so reduce always gets an array of arrays
 			return [listItem];
@@ -28,21 +48,14 @@ module.exports = function getComponentFiles(components, rootDir, ignore) {
 		return [];
 	}
 
-	let componentFiles;
-	if (isFunction(components)) {
-		componentFiles = getFilesMatchingGlobs(components(), rootDir, ignore);
-	} else if (Array.isArray(components)) {
-		componentFiles = getFilesMatchingGlobs(components, rootDir, ignore);
-	} else if (isString(components)) {
-		componentFiles = glob.sync(path.resolve(rootDir, components), { ignore });
-	} else {
-		throw new Error(
-			`Styleguidist: components should be string, function or array, received ${typeof components}.`
-		);
-	}
+	// Normalize components option into an Array
+	const componentGlobs = getComponentGlobs(components);
+
+	// Resolve list of components from globs
+	const componentFiles = getFilesMatchingGlobs(componentGlobs, rootDir, ignore);
 
 	// Make paths absolute
-	componentFiles = componentFiles.map(file => path.resolve(rootDir, file));
+	const componentFilesAbsolute = componentFiles.map(file => path.resolve(rootDir, file));
 
-	return componentFiles;
+	return componentFilesAbsolute;
 };