Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: strongloop/loopback
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9fb67315f9b9af4ae5e61ecef479888a8a9002f9
Choose a base ref
...
head repository: strongloop/loopback
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9b1d4885ab869d977bc7d464aa861b4f88691862
Choose a head ref
53 contributors

Commits on May 13, 2017

  1. update strong-error-handler

    @sqlwwx
    sqlwwx committed May 13, 2017
    Copy the full SHA
    ee68b80 View commit details

Commits on May 22, 2017

  1. Support remoting adapters with no ctx.req object 

    Fix `Model.createOptionsFromRemotingContext()` to correctly handle
the case where `ctx.req` is not defined, e.g. when using
websocket-based adapters.
    @pierissimo @bajtos
    pierissimo authored and bajtos committed May 22, 2017
    Copy the full SHA
    4735efa View commit details

  2. Merge pull request #3376 from pierissimo/patch-1 

    Support remoting adapters with no ctx.req object
    @bajtos
    bajtos authored May 22, 2017
    Copy the full SHA
    f8db64c View commit details

Commits on May 23, 2017

  1. Update package.json

    @sqlwwx
    sqlwwx authored May 23, 2017
    Copy the full SHA
    375d476 View commit details

  2. Update package.json

    @sqlwwx
    sqlwwx authored May 23, 2017
    Copy the full SHA
    3a10209 View commit details

  3. Merge pull request #3396 from sqlwwx/master 

    Update strong-error-handler to 2.x
    @bajtos
    bajtos authored May 23, 2017
    Copy the full SHA
    359a6a5 View commit details

Commits on Jun 14, 2017

  1. Fix API doc for Model class property type

    @0candy
    0candy committed Jun 14, 2017
    Copy the full SHA
    0498383 View commit details

  2. Merge pull request #3448 from strongloop/fix_type 

    Fix API doc for Model class property type
    @0candy
    0candy authored Jun 14, 2017
    Copy the full SHA
    1be0a9f View commit details

Commits on Jun 15, 2017

  1. Use localhost instead of :: for local

    @watilde
    watilde committed Jun 15, 2017
    Copy the full SHA
    75b4a45 View commit details

Commits on Jun 21, 2017

  1. Merge pull request #3450 from watilde/fixes-3179 

    Use `localhost` instead of `::` for local
    @bajtos
    bajtos authored Jun 21, 2017
    Copy the full SHA
    f85551b View commit details

Commits on Jun 23, 2017

  1. Fix Model#settings.acls doc type signature

    @faridnsh @bajtos
    faridnsh authored and bajtos committed Jun 23, 2017
    Copy the full SHA
    065eeda View commit details

  2. Merge pull request #3444 from alFReD-NSH/patch-2 

    Fix Model#settings.acls doc type signature
    @bajtos
    bajtos authored Jun 23, 2017
    Copy the full SHA
    ca3a21d View commit details

Commits on Jul 12, 2017

  1. Remove observers from Model on end of the stream 

     - Remove flags and properly finish the stream.
 - Destroy emits an end event for compability with ending of
   ReadableStream now.
 - Check for default implementation of destroy() method,
   because in Node.js 8 all types of streams have a native one.
    @bajtos
    Alexei Smirnov authored and bajtos committed Jul 12, 2017
    Copy the full SHA
    8ed92a1 View commit details

  2. Merge pull request #3474 from bigcup/fixChangeStreamIssue#1569 

    Removed observers from a Model after finish of the stream
    @bajtos
    bajtos authored Jul 12, 2017
    Copy the full SHA
    f7b88e3 View commit details

  3. 3.9.0 

     * Remove observers from Model on end of the stream (Alexei Smirnov)
 * Fix Model#settings.acls doc type signature (Farid Nouri Neshat)
 * Use `localhost` instead of `::` for local (Daijiro Wachi)
 * Fix API doc for Model class property type (Candy)
 * Update package.json (sqlwwx)
 * Support remoting adapters with no ctx.req object (Piero Maltese)
 * update strong-error-handler (sqlwwx)
    @bajtos
    bajtos committed Jul 12, 2017
    Copy the full SHA
    839c586 View commit details

Commits on Jul 25, 2017

  1. Add CODEOWNER file

    @dhmlau
    dhmlau committed Jul 25, 2017
    Copy the full SHA
    5ed74ab View commit details

  2. Merge pull request #3513 from strongloop/add-codeowner 

    Add CODEOWNER file
    @dhmlau
    dhmlau authored Jul 25, 2017
    Copy the full SHA
    d1f6129 View commit details

  3. Add unit test for empty password

    @loay
    loay committed Jul 25, 2017
    Copy the full SHA
    c761dc5 View commit details

  4. Update Travis registry

    @loay
    loay committed Jul 25, 2017
    Copy the full SHA
    a3bf813 View commit details

  5. Merge pull request #3511 from strongloop/empty-password-lb3 

    Add unit test for empty password
    @loay
    loay authored Jul 25, 2017
    Copy the full SHA
    131b78d View commit details

Commits on Jul 27, 2017

  1. Changed http to https 

    Changed the following links from HTTP to HTTPS as it is supported by loopback and strongloop
    @Alaev
    Alaev authored Jul 27, 2017
    Copy the full SHA
    1fcc40f View commit details

Commits on Jul 28, 2017

  1. small fix for the title 

    small fix for the title
    @Alaev
    Alaev authored Jul 28, 2017
    Copy the full SHA
    478e3f3 View commit details

  2. Merge pull request #3523 from Alaev/patch-4 

    Fixed broken link && Changed http to https
    @crandmck
    crandmck authored Jul 28, 2017
    Copy the full SHA
    8589629 View commit details

Commits on Aug 2, 2017

  1. update messages.json

    @dhmlau
    dhmlau committed Aug 2, 2017
    Copy the full SHA
    679ecbc View commit details

  2. Merge pull request #3537 from strongloop/translate 

    update messages.json
    @dhmlau
    dhmlau authored Aug 2, 2017
    Copy the full SHA
    deec84f View commit details

  3. Update juggler version

    @loay
    loay committed Aug 2, 2017
    Copy the full SHA
    7879ec3 View commit details

  4. Validate on updateAll

    @ssh24
    ssh24 committed Aug 2, 2017
    Copy the full SHA
    5dd0d19 View commit details

  5. Merge pull request #3541 from strongloop/add-validate-updateAll 

    Validate on updateAll
    Sakib Hasan authored Aug 2, 2017
    Copy the full SHA
    619a0e4 View commit details

Commits on Aug 3, 2017

  1. travis: drop Node.js 7.x, add 8.x

    @bajtos
    bajtos committed Aug 3, 2017
    Copy the full SHA
    3915c49 View commit details

  2. Merge pull request #3543 from strongloop/update/travis-platforms 

    travis: drop Node.js 7.x, add 8.x
    @bajtos
    bajtos authored Aug 3, 2017
    Copy the full SHA
    5562dca View commit details

  3. Add tests of HTTP normalization on app level 

    Also improve tests on model level to include nested routes

Add a test for HTTP normalization precedence too.
    @lehni @bajtos
    lehni authored and bajtos committed Aug 3, 2017
    Copy the full SHA
    5cd95e4 View commit details

  4. Merge pull request #3527 from lehni/feature/test-http-normalization 

    Add tests of HTTP normalization on app level
    @bajtos
    bajtos authored Aug 3, 2017
    Copy the full SHA
    d3d0ef4 View commit details

  5. Merge pull request #3538 from strongloop/juggler-version 

    Update juggler version
    @loay
    loay authored Aug 3, 2017
    Copy the full SHA
    2809d62 View commit details

  6. Revert "Validate on updateAll"

    @ssh24
    Sakib Hasan authored and ssh24 committed Aug 3, 2017
    Copy the full SHA
    2fd5701 View commit details

Commits on Aug 4, 2017

  1. Merge pull request #3545 from strongloop/revert-3541-add-validate-upd… 

    …ateAll

Revert "Validate on updateAll"
    Sakib Hasan authored Aug 4, 2017
    Copy the full SHA
    74cbe12 View commit details

Commits on Aug 10, 2017

  1. Update translated strings Q3 2017

    @kallenboone
    kallenboone committed Aug 10, 2017
    Copy the full SHA
    dcb190f View commit details

Commits on Aug 11, 2017

  1. Merge pull request #3555 from kallenboone/master 

    Update translated strings Q3 2017
    @bajtos
    bajtos authored Aug 11, 2017
    Copy the full SHA
    132ce4c View commit details

  2. Fix case of values per doc issue

    @crandmck
    crandmck committed Aug 11, 2017
    Copy the full SHA
    9f8321a View commit details

  3. Merge pull request #3559 from strongloop/acl-apidoc-fix 

    Fix case of values per doc issue
    @crandmck
    crandmck authored Aug 11, 2017
    Copy the full SHA
    df87c17 View commit details

Commits on Aug 14, 2017

  1. Allow glob-style patterns for remote options

    @zbarbuto
    zbarbuto committed Aug 14, 2017
    Copy the full SHA
    724a7d1 View commit details

  2. Merge pull request #3504 from zbarbuto/feature/share-method-glob 

    Allow glob-style patterns for remote options
    @bajtos
    bajtos authored Aug 14, 2017
    Copy the full SHA
    06a2b6d View commit details

  3. 3.10.0 

     * Allow glob-style patterns for remote options (Zak Barbuto)
 * Fix case of values per doc issue (crandmck)
 * Update translated strings Q3 2017 (Allen Boone)
 * Revert "Validate on updateAll" (Sakib Hasan)
 * Add tests of HTTP normalization on app level (Jürg Lehni)
 * travis: drop Node.js 7.x, add 8.x (Miroslav Bajtoš)
 * Validate on updateAll (ssh24)
 * Update juggler version (loay)
 * update messages.json (Diana Lau)
 * small fix for the title (Michael Alaev)
 * Changed http to https (Michael Alaev)
 * Update Travis registry (loay)
 * Add unit test for empty password (loay)
 * Add CODEOWNER file (Diana Lau)
    @bajtos
    bajtos committed Aug 14, 2017
    Copy the full SHA
    5db00c6 View commit details

Commits on Aug 15, 2017

  1. Do not add isStatic properties to method settings 

    Closes #3529
    @lehni
    lehni committed Aug 15, 2017
    Copy the full SHA
    a736f78 View commit details

Commits on Aug 16, 2017

  1. fix(validatePassword): reword error message 

    Reword the error message returned when the password is too long
 - remove the plaintext password value, it looks very bad
 - include information about the maximum allowed length instead

Also add additional context to the error.
    @STRML @bajtos
    STRML authored and bajtos committed Aug 16, 2017
    Copy the full SHA
    44dd048 View commit details

  2. Merge pull request #3556 from STRML/fix/validatePassword 

    fix(validatePassword): Reword password too long error.
    @bajtos
    bajtos authored Aug 16, 2017
    Copy the full SHA
    bc87789 View commit details

  3. Merge pull request #3540 from lehni/fix/isStatic-method-settings 

    Do not add isStatic properties to method settings
    @bajtos
    bajtos authored Aug 16, 2017
    Copy the full SHA
    2ebe38b View commit details

  4. 3.10.1 

     * fix(validatePassword): reword error message (Samuel Reed)
 * Do not add isStatic properties to method settings (Jürg Lehni)
    @bajtos
    bajtos committed Aug 16, 2017
    Copy the full SHA
    b1adba1 View commit details

  5. Update Issue and PR Templates (#3568) 

    * update issue template

* update pr template
    Sakib Hasan authored Aug 16, 2017
    Copy the full SHA
    b3602bd View commit details

Commits on Aug 17, 2017

  1. Catch errors on invalidate update

    @loay
    loay committed Aug 17, 2017
    Copy the full SHA
    bf4b5de View commit details

  2. Merge pull request #3570 from strongloop/catch-err 

    Catch errors on invalidate update
    @loay
    loay authored Aug 17, 2017
    Copy the full SHA
    4a8e3f1 View commit details
Showing with 5,138 additions and 1,927 deletions.
  1. +9 −1 .github/ISSUE_TEMPLATE.md
  2. +5 −4 .github/PULL_REQUEST_TEMPLATE.md
  3. +23 −0 .github/stale.yml
  4. +1 −0 .npmrc
  5. +4 −3 .travis.yml
  6. +390 −0 CHANGES.md
  7. +11 −0 CODEOWNERS
  8. +15 −5 Gruntfile.js
  9. +1 −1 LICENSE
  10. +32 −12 README.md
  11. +9 −4 common/models/access-token.js
  12. +0 −6 common/models/access-token.json
  13. +29 −18 common/models/acl.js
  14. +1 −1 common/models/application.js
  15. +9 −5 common/models/change.js
  16. +1 −1 common/models/checkpoint.js
  17. +1 −1 common/models/email.js
  18. +4 −3 common/models/key-value-model.js
  19. +1 −1 common/models/role-mapping.js
  20. +123 −20 common/models/role.js
  21. +3 −2 common/models/scope.js
  22. +120 −48 common/models/user.js
  23. +1 −1 example/client-server/client.js
  24. +1 −1 example/client-server/models.js
  25. +1 −1 example/client-server/server.js
  26. +1 −1 example/colors/app.js
  27. +6 −6 example/mobile-models/app.js
  28. +1 −1 example/replication/app.js
  29. +1 −1 example/simple-data-source/app.js
  30. +2 −1 index.js
  31. +93 −0 intl/cs/messages.json
  32. +24 −7 intl/de/messages.json
  33. +22 −5 intl/en/messages.json
  34. +25 −8 intl/es/messages.json
  35. +24 −7 intl/fr/messages.json
  36. +25 −8 intl/it/messages.json
  37. +22 −5 intl/ja/messages.json
  38. +35 −18 intl/ko/messages.json
  39. +25 −8 intl/nl/messages.json
  40. +93 −0 intl/pl/messages.json
  41. +23 −6 intl/pt/messages.json
  42. +93 −0 intl/ru/messages.json
  43. +24 −7 intl/tr/messages.json
  44. +25 −8 intl/zh-Hans/messages.json
  45. +26 −9 intl/zh-Hant/messages.json
  46. +7 −8 lib/access-context.js
  47. +76 −64 lib/application.js
  48. +1 −1 lib/browser-express.js
  49. +23 −12 lib/builtin-models.js
  50. +80 −0 lib/configure-shared-methods.js
  51. +1 −1 lib/connectors/base-connector.js
  52. +2 −4 lib/connectors/mail.js
  53. +1 −1 lib/connectors/memory.js
  54. +7 −4 lib/current-context.js
  55. +1 −1 lib/globalize.js
  56. +10 −2 lib/loopback.js
  57. +94 −55 lib/model.js
  58. +114 −69 lib/persisted-model.js
  59. +10 −6 lib/registry.js
  60. +1 −1 lib/runtime.js
  61. +9 −6 lib/server-app.js
  62. +3 −2 lib/utils.js
  63. +39 −27 package.json
  64. +3 −2 server/middleware/context.js
  65. +1 −1 server/middleware/error-handler.js
  66. +1 −1 server/middleware/favicon.js
  67. +3 −2 server/middleware/rest.js
  68. +1 −1 server/middleware/static.js
  69. +1 −1 server/middleware/status.js
  70. +4 −3 server/middleware/token.js
  71. +1 −1 server/middleware/url-not-found.js
  72. +5 −3 test/access-control.integration.js
  73. +73 −61 test/access-token.test.js
  74. +283 −212 test/acl.test.js
  75. +214 −45 test/app.test.js
  76. +14 −20 test/authorization-scopes.test.js
  77. +62 −2 test/change-stream.test.js
  78. +13 −12 test/change.test.js
  79. +6 −6 test/checkpoint.test.js
  80. +9 −5 test/context-options.test.js
  81. +1 −1 test/data-source.test.js
  82. +1 −1 test/e2e/remote-connector.e2e.js
  83. +1 −1 test/e2e/replication.e2e.js
  84. +1 −1 test/email.test.js
  85. +1 −1 test/error-handler.test.js
  86. +1 −1 test/fixtures/access-control/server/server.js
  87. +1 −1 test/fixtures/e2e/server/models.js
  88. +1 −1 test/fixtures/e2e/server/server.js
  89. +1 −1 test/fixtures/shared-methods/both-configs-set/common/models/todo.js
  90. +1 −1 test/fixtures/shared-methods/both-configs-set/server/server.js
  91. +1 −1 test/fixtures/shared-methods/config-default-false/common/models/todo.js
  92. +1 −1 test/fixtures/shared-methods/config-default-false/server/server.js
  93. +1 −1 test/fixtures/shared-methods/config-default-true/common/models/todo.js
  94. +1 −1 test/fixtures/shared-methods/config-default-true/server/server.js
  95. +1 −1 test/fixtures/shared-methods/config-defined-false/common/models/todo.js
  96. +1 −1 test/fixtures/shared-methods/config-defined-false/server/server.js
  97. +1 −1 test/fixtures/shared-methods/config-defined-true/common/models/todo.js
  98. +1 −1 test/fixtures/shared-methods/config-defined-true/server/server.js
  99. +1 −1 test/fixtures/shared-methods/model-config-default-false/common/models/todo.js
  100. +1 −1 test/fixtures/shared-methods/model-config-default-false/server/server.js
  101. +1 −1 test/fixtures/shared-methods/model-config-default-true/common/models/todo.js
  102. +1 −1 test/fixtures/shared-methods/model-config-default-true/server/server.js
  103. +1 −1 test/fixtures/shared-methods/model-config-defined-false/common/models/todo.js
  104. +1 −1 test/fixtures/shared-methods/model-config-defined-false/server/server.js
  105. +1 −1 test/fixtures/shared-methods/model-config-defined-true/common/models/todo.js
  106. +1 −1 test/fixtures/shared-methods/model-config-defined-true/server/server.js
  107. +1 −1 test/fixtures/simple-app/boot/foo.js
  108. +1 −1 test/fixtures/simple-app/common/models/bar.js
  109. +11 −0 test/fixtures/simple-integration-app/common/models/customer-forceid.json
  110. +4 −0 test/fixtures/simple-integration-app/server/model-config.json
  111. +1 −1 test/fixtures/simple-integration-app/server/server.js
  112. +1 −1 test/fixtures/user-integration-app/server/server.js
  113. +1 −1 test/geo-point.test.js
  114. +21 −0 test/helpers/error-loggers.js
  115. +1 −1 test/helpers/expect.js
  116. +1 −1 test/helpers/loopback-testing-helper.js
  117. +5 −0 test/helpers/use-english.js
  118. +1 −1 test/helpers/wait-for-event.js
  119. +12 −11 test/hidden-properties.test.js
  120. +3 −2 test/integration.test.js
  121. +1 −1 test/karma.conf.js
  122. +43 −38 test/key-value-model.test.js
  123. +169 −2 test/loopback.test.js
  124. +1 −1 test/memory.test.js
  125. +75 −75 test/model.application.test.js
  126. +56 −3 test/model.test.js
  127. +299 −0 test/multiple-user-principal-accessing-another-user-model.js
  128. +482 −178 test/multiple-user-principal-types.test.js
  129. +1 −1 test/registries.test.js
  130. +55 −32 test/relations.integration.js
  131. +1 −1 test/remote-connector.test.js
  132. +2 −3 test/remoting-coercion.test.js
  133. +88 −58 test/remoting.integration.js
  134. +18 −11 test/replication.rest.test.js
  135. +132 −96 test/replication.test.js
  136. +105 −45 test/rest.middleware.test.js
  137. +12 −9 test/role-mapping.test.js
  138. +523 −251 test/role.test.js
  139. +6 −4 test/user-password.test.js
  140. +35 −2 test/user.integration.js
  141. +355 −172 test/user.test.js
  142. +1 −1 test/util/describe.js
  143. +1 −1 test/util/it.js
  144. +28 −7 test/util/model-tests.js
  145. +1 −1 test/utils.test.js
10 changes: 9 additions & 1 deletion .github/ISSUE_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,15 @@ Immediate support:

<!--
If feature: A description of the feature
If bug: Steps to reproduce + link to sample repo
If bug: Steps to reproduce
-->

# Link to reproduction sandbox

<!--
Link to an app sandbox for reproduction
Note: Failure to provide a sandbox application for reproduction purposes will result in the issue being closed.
-->

# Expected result
9 changes: 5 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -6,17 +6,18 @@
<!--
Please use the following link syntaxes:
- #49 (to reference issues in the current repository)
- strongloop/loopback#49 (to reference issues in another repository)
- connect to #49 (to reference issues in the current repository)
- connect to strongloop/loopback#49 (to reference issues in another repository)
-->

- None
- connect to <link_to_referenced_issue>

### Checklist

<!--
Please mark your choice with an "x" (i.e. [x], see
- Please mark your choice with an "x" (i.e. [x], see
https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments)
- PR's without test coverage will be closed.
-->

- [ ] New tests added or existing tests modified to cover all changes
23 changes: 23 additions & 0 deletions .github/stale.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Number of days of inactivity before an issue becomes stale
daysUntilStale: 60
# Number of days of inactivity before a stale issue is closed
daysUntilClose: 14
# Issues with these labels will never be considered stale
exemptLabels:
- pinned
- security
- critical
- p1
- major
# Label to use when marking an issue as stale
staleLabel: stale
# Comment to post when marking an issue as stale. Set to `false` to disable
markComment: >
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.
# Comment to post when closing a stale issue. Set to `false` to disable
closeComment: >
This issue has been closed due to continued inactivity. Thank you for your understanding.
If you believe this to be in error, please contact one of the code owners,
listed in the [`CODEOWNERS`](https://github.com/strongloop/loopback/blob/master/CODEOWNERS) file at the top-level of this repository.
1 change: 1 addition & 0 deletions .npmrc
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
package-lock=false
7 changes: 4 additions & 3 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
sudo: false
language: node_js
node_js:
- "4"
- "6"
- "7"
- "8"
- "10"
- "12"

after_success: npm run coverage

@@ -12,6 +12,7 @@ cache:
directories:
- travis_phantomjs
before_install:
- npm config set registry http://ci.strongloop.com:4873/
# Upgrade PhantomJS to v2.1.1.
- "export PHANTOMJS_VERSION=2.1.1"
- "export PATH=$PWD/travis_phantomjs/phantomjs-$PHANTOMJS_VERSION-linux-x86_64/bin:$PATH"
Loading