This repository was archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: fork URL
and fetch
for React Native in web3.js
#26604
Merged
steveluscher
merged 1 commit into
solana-labs:master
from
steveluscher:fetch-and-url-for-react-native
Jul 13, 2022
Merged
fix: fork URL
and fetch
for React Native in web3.js
#26604
steveluscher
merged 1 commit into
solana-labs:master
from
steveluscher:fetch-and-url-for-react-native
Jul 13, 2022
+61
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automerge label removed due to a CI failure |
Codecov Report
@@ Coverage Diff @@
## master #26604 +/- ##
===========================================
- Coverage 81.9% 77.5% -4.4%
===========================================
Files 631 41 -590
Lines 174252 2374 -171878
Branches 0 343 +343
===========================================
- Hits 142728 1842 -140886
+ Misses 31524 405 -31119
- Partials 0 127 +127 |
Lcchy
pushed a commit
to Bonfida/solana
that referenced
this pull request
Jul 22, 2022
This was referenced Aug 3, 2022
This was referenced Aug 6, 2022
This was referenced Aug 19, 2022
This was referenced Aug 27, 2022
This was referenced Sep 3, 2022
This was referenced Sep 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
React Native has a kneecapped
URL
implementation, and uses a browser-likefetch
API. For web3.js to work in React Native we need to supply forks/polyfills.Summary of Changes
fetch
fork as we do for browsers