Skip to content

Commit f2b8de7

Browse files
authoredJan 4, 2022
fix(typings): pass SocketData type to custom namespaces (#4233)
The `SocketData` type was only available on the main namespace. Related: #4229 See also: fe8730c
1 parent 51784d0 commit f2b8de7

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed
 

‎lib/index.ts

+9-5
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,13 @@ export class Server<
112112
/**
113113
* @private
114114
*/
115-
_nsps: Map<string, Namespace<ListenEvents, EmitEvents, ServerSideEvents>> =
116-
new Map();
115+
_nsps: Map<
116+
string,
117+
Namespace<ListenEvents, EmitEvents, ServerSideEvents, SocketData>
118+
> = new Map();
117119
private parentNsps: Map<
118120
ParentNspNameMatchFn,
119-
ParentNamespace<ListenEvents, EmitEvents, ServerSideEvents>
121+
ParentNamespace<ListenEvents, EmitEvents, ServerSideEvents, SocketData>
120122
> = new Map();
121123
private _adapter?: AdapterConstructor;
122124
private _serveClient: boolean;
@@ -197,7 +199,9 @@ export class Server<
197199
name: string,
198200
auth: { [key: string]: any },
199201
fn: (
200-
nsp: Namespace<ListenEvents, EmitEvents, ServerSideEvents> | false
202+
nsp:
203+
| Namespace<ListenEvents, EmitEvents, ServerSideEvents, SocketData>
204+
| false
201205
) => void
202206
): void {
203207
if (this.parentNsps.size === 0) return fn(false);
@@ -579,7 +583,7 @@ export class Server<
579583
fn?: (
580584
socket: Socket<ListenEvents, EmitEvents, ServerSideEvents, SocketData>
581585
) => void
582-
): Namespace<ListenEvents, EmitEvents, ServerSideEvents> {
586+
): Namespace<ListenEvents, EmitEvents, ServerSideEvents, SocketData> {
583587
if (typeof name === "function" || name instanceof RegExp) {
584588
const parentNsp = new ParentNamespace(this);
585589
debug("initializing parent namespace %s", parentNsp.name);

0 commit comments

Comments
 (0)
Please sign in to comment.