Skip to content

Commit 30430f0

Browse files
committedMay 3, 2022
fix: forward the local flag to the adapter when using fetchSockets()
Related: - #4359 - socketio/socket.io-redis-adapter#454
1 parent 9b43c91 commit 30430f0

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed
 

‎lib/broadcast-operator.ts

+4
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ export class BroadcastOperator<EmitEvents extends EventsMap, SocketData>
262262
.fetchSockets({
263263
rooms: this.rooms,
264264
except: this.exceptRooms,
265+
flags: this.flags,
265266
})
266267
.then((sockets) => {
267268
return sockets.map((socket) => {
@@ -289,6 +290,7 @@ export class BroadcastOperator<EmitEvents extends EventsMap, SocketData>
289290
{
290291
rooms: this.rooms,
291292
except: this.exceptRooms,
293+
flags: this.flags,
292294
},
293295
Array.isArray(room) ? room : [room]
294296
);
@@ -305,6 +307,7 @@ export class BroadcastOperator<EmitEvents extends EventsMap, SocketData>
305307
{
306308
rooms: this.rooms,
307309
except: this.exceptRooms,
310+
flags: this.flags,
308311
},
309312
Array.isArray(room) ? room : [room]
310313
);
@@ -321,6 +324,7 @@ export class BroadcastOperator<EmitEvents extends EventsMap, SocketData>
321324
{
322325
rooms: this.rooms,
323326
except: this.exceptRooms,
327+
flags: this.flags,
324328
},
325329
close
326330
);

4 commit comments

Comments
 (4)

seankarson commented on May 10, 2022

@seankarson

@darrachequesne Any chance you could trigger a release that includes this change? I'd really appreciate it, and I'm happy to help in any way I can!

schw4rzlicht commented on May 16, 2022

@schw4rzlicht

I'd love to see this one released as well :)

derikb commented on May 17, 2022

@derikb

me as well

darrachequesne commented on May 17, 2022

@darrachequesne
MemberAuthor
Please sign in to comment.