Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When only receiving values with encoded array value, decode values #287

Merged
merged 3 commits into from Oct 17, 2020

Conversation

mishugana
Copy link
Contributor

Fixes #242
Now all 99 tests pass (instead of one failing on purpose)
when pasting my url that used a custom array separator into slack, it was uri encoded, which broke things.
now in situations like that, the simple case will work, but allows more complicated cases to also still work.

index.js Outdated Show resolved Hide resolved
@mishugana
Copy link
Contributor Author

I changed over the code to use the includes method. All tests still pass. If you think this is an ok pull request, and you dont mind, would you be able to tag this pull request with hacktoberfest-accepted (if it does get accepted) since I am trying to get one of those free t-shirts.

@sindresorhus sindresorhus merged commit b38f06c into sindresorhus:master Oct 17, 2020
@sindresorhus
Copy link
Owner

I assume merging will do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue for ISO 8601 dates on arrayFormat separator option
2 participants