use default http status messages

Author: dfenster

lib/http-status.js

@@ -1,4 +1,6 @@
+var http = require('http');
 var util = require('util');
+var _ = require('lodash');
 
 var STATUS_CODE_ATTRIBUTE_NAME = module.exports.STATUS_CODE_ATTRIBUTE_NAME = 'status';
 
@@ -59,31 +61,4 @@ var code_map = HttpStatusError.code_map = {
   "AlreadyInUseError": 409,
 };
 
-var message_map = HttpStatusError.message_map = {
-  400: "Bad Request!",
-  401: "Authentication Required!",
-  402: "Payment Required!",
-  403: "Forbidden!",
-  404: "Not Found!",
-  405: "Method not Allowed!",
-  406: "Response Type Not Acceptable!",
-  407: "Proxy Authentication Required!",
-  408: "Request Timeout!",
-  409: "Conflict!",
-  410: "Gone!",
-  411: "Content-Length Required!",
-  412: "Precondition Failed!",
-  413: "Request Entity Too Lage!",
-  414: "Request URI Too Long!",
-  415: "Unsupported Media Type!",
-  416: "Requested Range Not Satisfiable!",
-  417: "Expectation Failed!",
-  429: "Too Many Requests!",
-  500: "Internal Server Error!",
-  501: "Not Implemented!",
-  502: "Bad Gateway!",
-  503: "Service Unavailable!",
-  504: "Gateway Timeout!",
-  505: "HTTP Version Not Supported!"
-};
-
+var message_map = HttpStatusError.message_map = _.extend({}, http.STATUS_CODES);

tests/http-status.js

@@ -20,7 +20,7 @@ describe("HttpStatusError", function(){
 
   it("should work with status code", function(){
     var error = new HttpStatusError(403);
-    assert.equal(error.message, "(403) Forbidden!");
+    assert.equal(error.message, "(403) Forbidden");
     assert.equal(error.status, 403);
     assert.equal(error.status_code, 403);
     assert.equal(error.statusCode, 403);
@@ -38,7 +38,7 @@ describe("HttpStatusError", function(){
 
   it("should work with status code without new", function(){
     var error = HttpStatusError(403);
-    assert.equal(error.message, "(403) Forbidden!");
+    assert.equal(error.message, "(403) Forbidden");
     assert.equal(error.status, 403);
     assert.equal(error.status_code, 403);
     assert.equal(error.statusCode, 403);

tests/middleware/errorHandler.js

@@ -131,7 +131,7 @@ describe("errorHandler", function(){
     err = new Error("test");
     request.get('/error').end(function(err, res){
       assert.equal(res.res.statusCode, 500);
-      assert.equal(res.text, "Internal Server Error!");
+      assert.equal(res.text, "Internal Server Error");
       assert.ok(console.error.called);
       assert.ok(/test/.test(console.error.getCall(0).args[0]));
       done();
@@ -143,7 +143,7 @@ describe("errorHandler", function(){
     err.status = 544;
     request.get('/error').end(function(err, res){
       assert.equal(res.res.statusCode, 544);
-      assert.equal(res.text, "Internal Server Error!");
+      assert.equal(res.text, "Internal Server Error");
       assert.ok(console.error.called);
       assert.ok(/test/.test(console.error.getCall(0).args[0]));
       done();
@@ -154,7 +154,7 @@ describe("errorHandler", function(){
     err = new errors.HttpStatus('custom status message', 544);
     request.get('/error').end(function(err, res){
       assert.equal(res.res.statusCode, 544);
-      assert.equal(res.text, "Internal Server Error!");
+      assert.equal(res.text, "Internal Server Error");
       assert.ok(console.error.called);
       assert.ok(/custom status message/.test(console.error.getCall(0).args[0]));
       done();
@@ -165,7 +165,7 @@ describe("errorHandler", function(){
     err = new errors.HttpStatus(544, 'custom status message')
     request.get('/error').end(function(err, res){
       assert.equal(res.res.statusCode, 544);
-      assert.equal(res.text, "Internal Server Error!");
+      assert.equal(res.text, "Internal Server Error");
       assert.ok(console.error.called);
       assert.ok(/custom status message/.test(console.error.getCall(0).args[0]));
       done();