test bluebird try/catch

Author: dfenster

package.json

@@ -2,7 +2,7 @@
   "name": "common-errors",
   "author": "David Fenster <david@dfenster.com>",
   "description": "Common error classes and utility functions",
-  "version": "0.5.4",
+  "version": "0.5.5",
   "repository": {
     "type": "git",
     "url": "https://github.com/shutterstock/node-common-errors.git"
@@ -14,6 +14,7 @@
     }
   ],
   "dependencies": {
+    "bluebird": "^3.4.0"
   },
   "devDependencies": {
     "mocha": "*",

tests/already-in-use.js

@@ -1,4 +1,5 @@
 var assert = require('assert');
+var Promise = require('bluebird');
 var errors = require('..');
 var name = "AlreadyInUseError";
 var Err = errors[name];
@@ -10,5 +11,15 @@ describe(name, function(){
     assert.equal(error.message, "The specified 'Entity' value is already in use for: att1, att2, att3, att4");
     assert.ok(new RegExp(error.name + ": " + error.message + "\n(.*\n)+").test(error.stack), "Stack is good");
     assert.ok(error instanceof Error, "It is an instanceof Error");
+
+    var caught_error_in_promise = false;
+    var promise = new Promise(function(res, rej) { res(true); }).then(function(){
+      throw new opts.extends("test error");
+    }).catch(Error, function(e){
+      caught_error_in_promise = true;
+    }).finally(function(){
+      assert.ok(caught_error_in_promise, "caught promise error");
+    });
+
   });
 });

tests/support/index.js

@@ -1,5 +1,6 @@
 var assert = require('assert');
 var errors = require('../..');
+var Promise = require('bluebird');
 
 module.exports.testError = function testError(name, opts){
   opts = opts || {};
@@ -13,7 +14,17 @@ module.exports.testError = function testError(name, opts){
     assert.equal(error.message, opts.message_to_assert);
     assert.ok(new RegExp(error.name + ": " + error.message + "\n(.*\n)+").test(error.stack), "Stack is good");
     assert.equal(Err.super_.name, opts.extends.name, "It is an instance of" + opts.extends.name);
-    assert.ok(error instanceof Error, opts.extends, "It is an instanceof " + opts.extends.name);  
+    assert.ok(error instanceof Error, "It is an instanceof Error");
+    assert.ok(error instanceof opts.extends, "It is an instanceof " + opts.extends.name);
+
+    var caught_error_in_promise = false;
+    var promise = new Promise(function(res, rej) { res(true); }).then(function(){
+      throw new opts.extends("test error");
+    }).catch(opts.extends, function(e){
+      caught_error_in_promise = true;
+    }).finally(function(){
+      assert.ok(caught_error_in_promise, "caught promise error");
+    });
   }  
 
   describe(name, function(){