Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): returning can specify column names #13215

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

JacobLey
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Update returning to match other methods like bulkCreate: https://github.com/sequelize/sequelize/blob/main/types/lib/model.d.ts#L772

Test was updated with attributes to enforce valid values, rather than any

Sorry, something went wrong.

@papb papb merged commit 143cc84 into sequelize:main Jun 25, 2021
@papb
Copy link
Member

papb commented Jun 25, 2021

Thank you!!

yocontra pushed a commit to yocontra/sequelize that referenced this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants