Skip to content

Commit dea15cd

Browse files
authoredSep 21, 2023
Remove all mentions to buidler (#778)
1 parent b56f209 commit dea15cd

File tree

6 files changed

+11
-40
lines changed

6 files changed

+11
-40
lines changed
 

‎.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
- checkout
5757
- <<: *step_install_nvm
5858
- run:
59-
name: Buidler & Hardhat E2E
59+
name: Hardhat E2E
6060
command: |
6161
./scripts/run-nomiclabs.sh
6262
workflows:

‎HARDHAT_README.md

-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ More documentation, including FAQ and information about solidity-coverage's API
128128
[29]: https://github.com/sc-forks/solidity-coverage/blob/master/docs/upgrade.md#upgrading-from-06x-to-070
129129
[30]: https://github.com/sc-forks/solidity-coverage/tree/0.6.x-final#solidity-coverage
130130
[31]: https://github.com/sc-forks/solidity-coverage/releases/tag/v0.7.0
131-
[32]: https://github.com/sc-forks/buidler-e2e/tree/coverage
132131
[33]: https://github.com/sc-forks/moloch
133132
[34]: https://github.com/sc-forks/solidity-coverage/blob/master/docs/advanced.md#reducing-the-instrumentation-footprint
134133

‎README.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
![npm (tag)](https://img.shields.io/npm/v/solidity-coverage/latest)
55
[![CircleCI](https://circleci.com/gh/sc-forks/solidity-coverage.svg?style=svg)][20]
66
[![codecov](https://codecov.io/gh/sc-forks/solidity-coverage/branch/master/graph/badge.svg)][21]
7-
[![buidler](https://buidler.dev/buidler-plugin-badge.svg?1)][26]
7+
[![Hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)][26]
88

99

1010
## Code coverage for Solidity testing
@@ -197,13 +197,12 @@ $ yarn
197197
[23]: https://github.com/sc-forks/solidity-coverage/blob/master/docs/advanced.md#workflow-hooks
198198
[24]: https://github.com/sc-forks/solidity-coverage/blob/master/docs/advanced.md#skipping-tests
199199
[25]: https://github.com/sc-forks/solidity-coverage/issues/417
200-
[26]: https://buidler.dev/
200+
[26]: https://hardhat.org/
201201
[27]: https://www.trufflesuite.com/docs
202202
[28]: https://github.com/sc-forks/solidity-coverage/blob/master/docs/api.md
203203
[29]: https://github.com/sc-forks/solidity-coverage/blob/master/docs/upgrade.md#upgrading-from-06x-to-070
204204
[30]: https://github.com/sc-forks/solidity-coverage/tree/0.6.x-final#solidity-coverage
205205
[31]: https://github.com/sc-forks/solidity-coverage/releases/tag/v0.7.0
206-
[32]: https://github.com/sc-forks/buidler-e2e/tree/coverage
207206
[33]: https://github.com/sc-forks/moloch
208207
[34]: https://github.com/sc-forks/solidity-coverage/blob/master/docs/advanced.md#reducing-the-instrumentation-footprint
209208
[35]: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/e5fbbda9bac49039847a7ed20c1d966766ecc64a/scripts/coverage.js

‎docs/api.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ table below shows how its core methods relate to the stages of a test run:
2020
disposable set of contracts/artifacts which coverage must use in lieu of the 'real' (uninstrumented)
2121
contracts.
2222

23-
+ there are two complete [coverage tool/plugin implementations][5] (for Buidler and Truffle)
23+
+ there are two complete [coverage tool/plugin implementations][5] (for Hardhat and Truffle)
2424
which can be used as sources if you're building something similar.
2525

2626
[5]: https://github.com/sc-forks/solidity-coverage/tree/master/plugins

‎plugins/resources/nomiclabs.utils.js

+6-33
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,16 @@ const util = require('util')
1818
function getTestFilePaths(files){
1919
const target = globby.sync([files])
2020

21-
// Buidler/Hardhat supports js & ts
21+
// Hardhat supports js & ts
2222
const testregex = /.*\.(js|ts)$/;
2323
return target.filter(f => f.match(testregex) != null);
2424
}
2525

2626
/**
27-
* Normalizes Buidler/Hardhat paths / logging for use by the plugin utilities and
27+
* Normalizes Hardhat paths / logging for use by the plugin utilities and
2828
* attaches them to the config
29-
* @param {Buidler/HardhatConfig} config
30-
* @return {Buidler/HardhatConfig} updated config
29+
* @param {HardhatConfig} config
30+
* @return {HardhatConfig} updated config
3131
*/
3232
function normalizeConfig(config, args={}){
3333
config.workingDir = config.paths.root;
@@ -49,32 +49,6 @@ function normalizeConfig(config, args={}){
4949
return config;
5050
}
5151

52-
function setupBuidlerNetwork(env, api, ui){
53-
const { createProvider } = require("@nomiclabs/buidler/internal/core/providers/construction");
54-
55-
let networkConfig = {};
56-
57-
let networkName = (env.buidlerArguments.network !== 'buidlerevm')
58-
? env.buidlerArguments.network
59-
: api.defaultNetworkName;
60-
61-
if (networkName !== api.defaultNetworkName){
62-
networkConfig = env.config.networks[networkName];
63-
configureHttpProvider(networkConfig, api, ui)
64-
} else {
65-
networkConfig.url = `http://${api.host}:${api.port}`
66-
}
67-
68-
const provider = createProvider(networkName, networkConfig);
69-
70-
return configureNetworkEnv(
71-
env,
72-
networkName,
73-
networkConfig,
74-
provider
75-
)
76-
}
77-
7852
async function setupHardhatNetwork(env, api, ui){
7953
const hardhatPackage = require('hardhat/package.json');
8054
const { createProvider } = require("hardhat/internal/core/providers/construction");
@@ -244,7 +218,7 @@ function setNetworkFrom(networkConfig, accounts){
244218
// TODO: Hardhat cacheing??
245219
/**
246220
* Generates a path to a temporary compilation cache directory
247-
* @param {BuidlerConfig} config
221+
* @param {HardhatConfig} config
248222
* @return {String} .../.coverage_cache
249223
*/
250224
function tempCacheDir(config){
@@ -253,7 +227,7 @@ function tempCacheDir(config){
253227

254228
/**
255229
* Silently removes temporary folders and calls api.finish to shut server down
256-
* @param {Buidler/HardhatConfig} config
230+
* @param {HardhatConfig} config
257231
* @param {SolidityCoverage} api
258232
* @return {Promise}
259233
*/
@@ -277,7 +251,6 @@ module.exports = {
277251
normalizeConfig,
278252
finish,
279253
tempCacheDir,
280-
setupBuidlerNetwork,
281254
setupHardhatNetwork,
282255
getTestFilePaths,
283256
setNetworkFrom,

‎scripts/run-nomiclabs.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/usr/bin/env bash
22
#
3-
# E2E CI: installs PR candidate on sc-forks/buidler-e2e (a simple example,
3+
# E2E CI: installs PR candidate on sc-forks/hardhat-e2e (a simple example,
44
# similar to Metacoin) and runs coverage
55
#
66

0 commit comments

Comments
 (0)
Please sign in to comment.