Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: request/request-promise-native
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1874877850a59152915c9e9cbacbdc577486cca5
Choose a base ref
...
head repository: request/request-promise-native
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 578970f57e6821fd3e01028cc2239084d9b2bb7f
Choose a head ref

Commits on Jan 9, 2019

  1. Copy the full SHA
    049152b View commit details

Commits on Jan 14, 2019

  1. Update package.json

    jasonmit authored Jan 14, 2019
    Copy the full SHA
    9cfcaaa View commit details

Commits on Feb 14, 2019

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    14aa6ee View commit details
  2. 6
    Copy the full SHA
    4633d4c View commit details
  3. Copy the full SHA
    67f7ed2 View commit details
  4. Merge pull request #33 from jasonmit/u/jasonmit/fix-node-6

    fix: target tough-cookie 2.x to preserve node 6 support
    analog-nico authored Feb 14, 2019
    Copy the full SHA
    c2c54c4 View commit details
  5. Copy the full SHA
    ad529a3 View commit details
  6. Version 1.0.6

    analog-nico committed Feb 14, 2019
    Copy the full SHA
    80947a1 View commit details
  7. Copy the full SHA
    1240b80 View commit details

Commits on Feb 15, 2019

  1. Copy the full SHA
    7ad655a View commit details
  2. Copy the full SHA
    7c5f721 View commit details
  3. fix: tough-cookie version

    analog-nico committed Feb 15, 2019
    Copy the full SHA
    ecf8621 View commit details
  4. Version 1.0.7

    analog-nico committed Feb 15, 2019
    1
    Copy the full SHA
    2ae195a View commit details

Commits on May 12, 2019

  1. docs: es6+, finally

    tbjgolden committed May 12, 2019
    Copy the full SHA
    239ce46 View commit details

Commits on Aug 6, 2019

  1. Merge pull request #46 from tbjgolden/docs/clarify-es6-finally

    docs: es6+, finally
    analog-nico authored Aug 6, 2019
    Copy the full SHA
    171f3b5 View commit details

Commits on Nov 4, 2019

  1. Copy the full SHA
    1592a31 View commit details
  2. Copy the full SHA
    3e8df67 View commit details
  3. Version 1.0.8

    analog-nico committed Nov 4, 2019
    Copy the full SHA
    6498be1 View commit details

Commits on Feb 14, 2020

  1. Copy the full SHA
    086632b View commit details

Commits on Feb 15, 2020

  1. Merge pull request #58 from shisama/readme-shows-deprecation

    docs: deprecated as well as request
    analog-nico authored Feb 15, 2020
    Copy the full SHA
    1165c4e View commit details

Commits on Mar 15, 2020

  1. Copy the full SHA
    f53ac09 View commit details

Commits on Jul 22, 2020

  1. Copy the full SHA
    8388f42 View commit details
  2. Version 1.0.9

    analog-nico committed Jul 22, 2020
    Copy the full SHA
    578970f View commit details
Showing with 37 additions and 10 deletions.
  1. +1 −1 .publishrc
  2. +6 −0 .travis.yml
  3. +1 −1 LICENSE
  4. +24 −3 README.md
  5. +4 −4 package.json
  6. +1 −1 test/spec/request-test.js
2 changes: 1 addition & 1 deletion .publishrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"validations": {
"vulnerableDependencies": true,
"vulnerableDependencies": false,
"uncommittedChanges": true,
"untrackedFiles": true,
"sensitiveData": true,
6 changes: 6 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -11,7 +11,13 @@ matrix:
env: V_REQUEST=latest
- node_js: "6"
env: V_REQUEST=latest
- node_js: "8"
env: V_REQUEST=latest
- node_js: "10"
env: V_REQUEST=latest

before_install:
- npm install tough-cookie
- npm install request@$V_REQUEST

install: npm install
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ISC License

Copyright (c) 2017, Nicolai Kamenzky and contributors
Copyright (c) 2020, Nicolai Kamenzky and contributors

Permission to use, copy, modify, and/or distribute this software for any
purpose with or without fee is hereby granted, provided that the above
27 changes: 24 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -10,11 +10,19 @@
[![Dependency Status](https://img.shields.io/david/request/request-promise-native.svg?style=flat-square&maxAge=2592000)](https://david-dm.org/request/request-promise-native)
[![Known Vulnerabilities](https://snyk.io/test/npm/request-promise-native/badge.svg?style=flat-square&maxAge=2592000)](https://snyk.io/test/npm/request-promise-native)

This package is similar to [`request-promise`](https://www.npmjs.com/package/request-promise) but uses native ES6 promises.
# Deprecated!

As of Feb 11th 2020, [`request`](https://github.com/request/request) is fully deprecated. No new changes are expected to land. In fact, none have landed for some time. This package is also deprecated because it depends on `request`.

Fyi, here is the [reasoning of `request`'s deprecation](https://github.com/request/request/issues/3142) and a [list of alternative libraries](https://github.com/request/request/issues/3143).

---

This package is similar to [`request-promise`](https://www.npmjs.com/package/request-promise) but uses native ES6+ promises.

Please refer to the [`request-promise` documentation](https://www.npmjs.com/package/request-promise). Everything applies to `request-promise-native` except the following:
- Instead of using Bluebird promises this library uses native ES6 promises.
- Mind that native ES6 promises have fewer features than Bluebird promises do. In particular, the `.finally(...)` method is not available.
- Instead of using Bluebird promises this library uses native ES6+ promises.
- Native ES6+ promises may have fewer features than Bluebird promises do. In particular, the `.finally(...)` method was not included until Node v10.

## Installation

@@ -49,6 +57,19 @@ If you want to debug a test you should use `gulp test-without-coverage` to run a

## Change History

- v1.0.9 (2020-07-21)
- Security fix: bumped `request-promise-core` which bumps `lodash` to `^4.17.19` following [this advisory](https://www.npmjs.com/advisories/1523).
- v1.0.8 (2019-11-03)
- Security fix: bumped `request-promise-core` which bumps `lodash` to `^4.17.15`. See [vulnerabilty reports](https://snyk.io/vuln/search?q=lodash&type=npm).
*(Thanks to @aw-davidson for reporting this in issue [#49](https://github.com/request/request-promise-native/issues/49).)*
- v1.0.7 (2019-02-14)
- Corrected mistakenly set `tough-cookie` version, now `^2.3.3`
*(Thanks to @evocateur for pointing this out.)*
- If you installed `request-promise-native@1.0.6` please make sure after the upgrade that `request` and `request-promise-native` use the same physical copy of `tough-cookie`.
- v1.0.6 (2019-02-14)
- Using stricter `tough-cookie@~2.3.3` to avoid installing `tough-cookie@3` which introduces breaking changes
*(Thanks to @jasonmit for pull request [#33](https://github.com/request/request-promise-native/pull/33/))*
- Security fix: bumped `lodash` to `^4.17.11`, see [vulnerabilty reports](https://snyk.io/vuln/search?q=lodash&type=npm)
- v1.0.5 (2017-09-22)
- Upgraded `tough-cookie` to a version without regex DoS vulnerability
*(Thanks to @sophieklm for [pull request #13](https://github.com/request/request-promise-native/pull/13))*
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "request-promise-native",
"version": "1.0.5",
"version": "1.0.9",
"description": "The simplified HTTP request client 'request' with Promise support. Powered by native ES6 promises.",
"keywords": [
"xhr",
@@ -33,9 +33,9 @@
"node": ">=0.12.0"
},
"dependencies": {
"request-promise-core": "1.1.1",
"stealthy-require": "^1.1.0",
"tough-cookie": ">=2.3.3"
"request-promise-core": "1.1.4",
"stealthy-require": "^1.1.1",
"tough-cookie": "^2.3.3"
},
"peerDependencies": {
"request": "^2.34"
2 changes: 1 addition & 1 deletion test/spec/request-test.js
Original file line number Diff line number Diff line change
@@ -146,7 +146,7 @@ describe('Request-Promise-Native', function () {
var cookiejar = rp.jar();

expect(function () {
cookiejar.setCookie(sessionCookie, 'https://api.mydomain.com');
cookiejar.setCookie(sessionCookie.toString(), 'https://api.mydomain.com');
}).to.not.throw();

});