Skip to content

Commit 97ed0e1

Browse files
committedMay 17, 2022
chore: format
1 parent aa39050 commit 97ed0e1

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed
 

‎.vscode/deno_resolve_npm_imports.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@
1010
"mime": "https://esm.sh/mime@3.0.0",
1111
"@remix-run/server-runtime": "https://esm.sh/@remix-run/server-runtime@1.4.3"
1212
}
13-
}
13+
}

‎.vscode/settings.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
{
22
"typescript.tsdk": "node_modules/typescript/lib",
3-
"deno.enablePaths": [
4-
"./packages/remix-deno/",
5-
],
3+
"deno.enablePaths": ["./packages/remix-deno/"],
64
"deno.importMap": "./.vscode/deno_resolve_npm_imports.json"
75
}

‎docs/decisions/0001-use-npm-to-manage-npm-dependencies-for-deno-projects.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Deno has three ways to manage dependencies:
1515
Additionally, NPM packages can be accessed as Deno modules via [Deno-friendly CDNs](https://deno.land/manual/node/cdns#deno-friendly-cdns) like https://esm.sh .
1616

1717
Remix has some requirements around dependencies:
18+
1819
- Remix treeshakes dependencies that are free of side-effects.
1920
- Remix sets the environment (dev/prod/test) across all code, including dependencies, at runtime via the `NODE_ENV` environment variable.
2021
- Remix depends on some NPM packages that should be specified as peer dependencies (notably, `react` and `react-dom`).
@@ -86,6 +87,7 @@ Remix will not yet support import maps.
8687
Users may configure an import map for the [Deno extension for VS Code](denoland.vscode-deno) to enable type hints for NPM-managed dependencies within their Deno editor:
8788

8889
`.vscode/resolve_npm_imports_in_deno.json`
90+
8991
```json
9092
{
9193
"// This import map is used solely for the denoland.vscode-deno extension.": "",
@@ -102,9 +104,10 @@ Users may configure an import map for the [Deno extension for VS Code](denoland.
102104
```
103105

104106
`.vscode/settings.json`
107+
105108
```json
106109
{
107110
"deno.enable": true,
108111
"deno.importMap": "./.vscode/resolve_npm_imports_in_deno.json"
109112
}
110-
```
113+
```

‎integration/helpers/deno-template/app/entry.server.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ export default function handleRequest(
77
request: Request,
88
responseStatusCode: number,
99
responseHeaders: Headers,
10-
remixContext: EntryContext,
10+
remixContext: EntryContext
1111
) {
12-
const markup = renderToString(
13-
<RemixServer context={remixContext} url={request.url} />,
12+
let markup = renderToString(
13+
<RemixServer context={remixContext} url={request.url} />
1414
);
1515

1616
responseHeaders.set("Content-Type", "text/html");

‎templates/deno/package.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,18 @@
1111
"lint": "deno lint --ignore=node_modules",
1212
"format": "deno fmt --ignore=node_modules"
1313
},
14+
"dependencies": {
15+
"@remix-run/deno": "*",
16+
"@remix-run/react": "*",
17+
"react": "^17.0.2",
18+
"react-dom": "^17.0.2"
19+
},
1420
"devDependencies": {
1521
"@remix-run/dev": "*",
1622
"cross-env": "^7.0.3",
1723
"npm-run-all": "^4.1.5"
1824
},
1925
"engines": {
2026
"node": ">=14"
21-
},
22-
"dependencies": {
23-
"@remix-run/deno": "*",
24-
"@remix-run/react": "*",
25-
"react": "^17.0.2",
26-
"react-dom": "^17.0.2"
2727
}
2828
}

0 commit comments

Comments
 (0)
Please sign in to comment.