build: support Gradle configuration cache (#2201)

* build: support configuration caching in cli-platform-android

Directly using Runtime.exec breaks Gradle configuration caching. This change is to use `providers.exec` which supports configuration caching. This is a minimal fix; it's likely possible that more invasive changes could be useful to avoid having to exec these processes at all until their values are needed, but I have not looked into larger structural changes.

* Update packages/cli-platform-android/native_modules.gradle

Co-authored-by: Nicola Corti <corti.nico@gmail.com>

* fix: pass providers into ReactNativeModules

---------

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Co-authored-by: Nicola Corti <corti.nico@gmail.com>

Author: 3 people

packages/cli-platform-android/native_modules.gradle

@@ -138,6 +138,7 @@ void rncli_registerProviders(std::shared_ptr<ComponentDescriptorProviderRegistry
 
 class ReactNativeModules {
   private Logger logger
+  private ProviderFactory providers
   private String packageName
   private File root
   private ArrayList<HashMap<String, String>> reactNativeModules
@@ -147,8 +148,9 @@ class ReactNativeModules {
 
   private static String LOG_PREFIX = ":ReactNative:"
 
-  ReactNativeModules(Logger logger, File root) {
+  ReactNativeModules(Logger logger, ProviderFactory providers, File root) {
     this.logger = logger
+    this.providers = providers
     this.root = root
 
     def (nativeModules, reactNativeModulesBuildVariants, androidProject, reactNativeVersion) = this.getReactNativeConfig()
@@ -366,29 +368,20 @@ class ReactNativeModules {
   }
 
   /**
-   * Runs a specified command using Runtime exec() in a specified directory.
+   * Runs a specified command using providers.exec in a specified directory.
    * Throws when the command result is empty.
    */
   String getCommandOutput(String[] command, File directory) {
     try {
-      def output = ""
-      def cmdProcess = Runtime.getRuntime().exec(command, null, directory)
-      def bufferedReader = new BufferedReader(new InputStreamReader(cmdProcess.getInputStream()))
-      def buff = ""
-      def readBuffer = new StringBuffer()
-      while ((buff = bufferedReader.readLine()) != null) {
-        readBuffer.append(buff)
+      def execOutput = providers.exec {
+        commandLine(command)
+        workingDir(directory)
       }
-      output = readBuffer.toString()
+      def output = execOutput.standardOutput.asText.get().trim()
       if (!output) {
         this.logger.error("${LOG_PREFIX}Unexpected empty result of running '${command}' command.")
-        def bufferedErrorReader = new BufferedReader(new InputStreamReader(cmdProcess.getErrorStream()))
-        def errBuff = ""
-        def readErrorBuffer = new StringBuffer()
-        while ((errBuff = bufferedErrorReader.readLine()) != null) {
-          readErrorBuffer.append(errBuff)
-        }
-        throw new Exception(readErrorBuffer.toString())
+        def error = execOutput.standardError.asText.get().trim()
+        throw new Exception(error)
       }
       return output
     } catch (Exception exception) {
@@ -486,7 +479,7 @@ class ReactNativeModules {
  */
 def projectRoot = rootProject.projectDir
 
-def autoModules = new ReactNativeModules(logger, projectRoot)
+def autoModules = new ReactNativeModules(logger, providers, projectRoot)
 
 def reactNativeVersionRequireNewArchEnabled(autoModules) {
     def rnVersion = autoModules.reactNativeVersion