UPDATE node 18.2.0 (#3825)

* UPDATE node 18.2.0

* FIX node.js v18.2.0 problems

* FIX test for error

* UPDATE dexie js

* UPDATE react

* UPDATE react-scripts

* UPDATE node to 18.3.0

* TRY fix react-native example

* FIX ci

* FIX ci again

Author: pubkey

.github/workflows/main.yml

@@ -444,7 +444,8 @@ jobs:
       - name: Set node version
         uses: actions/setup-node@v3
         with:
-          node-version-file: '.nvmrc'
+        # TODO using latest node version does not work with react native
+          node-version: 16.15.0
 
       - name: Reuse npm cache folder
         uses: actions/cache@v2

.nvmrc

@@ -1 +1 @@
-v16.15.0
+v18.3.0

CHANGELOG.md

@@ -3,6 +3,7 @@
 
 <!-- CHANGELOG NEWEST -->
 
+- UPDATE Node.js to version `18.3.0`
 - FIX: RxStorage should never emit an eventBulk with an empty events array.
 - Update PouchDB to `7.3.0` Thanks [@cetsupport](https://github.com/cetsupport).
 - CHANGE (RxStorage) revision hash must not include the `_meta` field.

examples/react/package.json

@@ -9,13 +9,13 @@
     "pouchdb-adapter-idb": "7.2.2",
     "pouchdb-replication": "7.2.2",
     "pouchdb-server": "4.2.0",
-    "react": "17.0.2",
-    "react-dom": "17.0.2",
+    "react": "18.1.0",
+    "react-dom": "18.1.0",
     "rxdb": "file:rxdb-local.tgz",
     "rxjs": "7.5.5"
   },
   "devDependencies": {
-    "react-scripts": "4.0.3",
+    "react-scripts": "5.0.1",
     "rimraf": "3.0.2",
     "testcafe": "1.18.6",
     "local-web-server": "5.1.1"

src/util.ts

@@ -529,6 +529,8 @@ export function isMaybeReadonlyArray(x: any): x is MaybeReadonly<any[]> {
     return Array.isArray(x);
 }
 
+
+const USE_NODE_BLOB_BUFFER_METHODS = typeof FileReader === 'undefined';
 export const blobBufferUtil = {
     /**
      * depending if we are on node or browser,
@@ -547,16 +549,16 @@ export const blobBufferUtil = {
             } as any);
         }
 
-        try {
-            // for browsers
-            blobBuffer = new Blob([data], {
-                type
-            } as any);
-        } catch (e) {
+        if (USE_NODE_BLOB_BUFFER_METHODS) {
             // for node
             blobBuffer = Buffer.from(data, {
                 type
             } as any);
+        } else {
+            // for browsers
+            blobBuffer = new Blob([data], {
+                type
+            } as any);
         }
 
         return blobBuffer;
@@ -578,23 +580,23 @@ export const blobBufferUtil = {
             );
         }
 
-        try {
+
+        if (USE_NODE_BLOB_BUFFER_METHODS) {
+            // for node
+            blobBuffer = Buffer.from(
+                base64String,
+                'base64'
+            );
+            return blobBuffer;
+        } else {
             /**
              * For browsers.
              * @link https://ionicframework.com/blog/converting-a-base64-string-to-a-blob-in-javascript/
              */
             const base64Response = await fetch(`data:${type};base64,${base64String}`);
             const blob = await base64Response.blob();
             return blob;
-        } catch (e) {
-            // for node
-            blobBuffer = Buffer.from(
-                base64String,
-                'base64'
-            );
         }
-
-        return blobBuffer;
     },
     isBlobBuffer(data: any): boolean {
         if ((typeof Buffer !== 'undefined' && Buffer.isBuffer(data)) || data instanceof Blob) {
@@ -607,7 +609,8 @@ export const blobBufferUtil = {
         if (typeof blobBuffer === 'string') {
             return Promise.resolve(blobBuffer);
         }
-        if (typeof Buffer !== 'undefined' && blobBuffer instanceof Buffer) {
+
+        if (USE_NODE_BLOB_BUFFER_METHODS) {
             // node
             return nextTick()
                 .then(() => blobBuffer.toString());

test/unit/replication-graphql.test.ts

@@ -39,6 +39,7 @@ import {
 import {
     getLastPullDocument,
     getLastPushCheckpoint,
+    RxReplicationError,
     setLastPullDocument
 } from '../../plugins/replication';
 import * as schemas from '../helper/schemas';
@@ -1413,7 +1414,10 @@ describe('replication-graphql.test.ts', () => {
                     first()
                 ).toPromise();
 
-                assert.ok(ensureNotFalsy(error).toString().includes('foobar'));
+                if (!error || (error as RxReplicationError<any>).type !== 'pull') {
+                    console.dir(error);
+                    throw error;
+                }
 
                 replicationState.cancel();
                 c.database.destroy();