Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ref typing of forwardRef #3214

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Fix ref typing of forwardRef #3214

merged 3 commits into from
Oct 12, 2021
+1 −1

Conversation

itkrt2y
Copy link
Contributor

@itkrt2y itkrt2y commented Jul 2, 2021

forwardRef accpets RefCallback as well as RefObject. To accept RefCallback, use Ref instead of RefObject .

@leaysgur leaysgur mentioned this pull request Jul 2, 2021
Closed
@cmlenz cmlenz mentioned this pull request Jul 13, 2021
Merged
@Pringels
Copy link

Any reason not to merge this?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.624% when pulling fdf7f1b on itkrt2y:master into d78746c on preactjs:master.

@JoviDeCroock JoviDeCroock merged commit 51bfe15 into preactjs:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit

@JoviDeCroock JoviDeCroock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@itkrt2y @Pringels @coveralls @developit @JoviDeCroock