-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(utils): atomWithObservable #1426
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7e79ad2:
|
src/utils/atomWithObservable.ts
Outdated
initialValue?: TData | InitialValueFunction<TData> | ||
type Options<Data> = { | ||
initialValue?: Data | (() => Data) | ||
timeout?: number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new option is still an undocumented one. It only exists to avoid memory leaks with concurrent rendering. we are not sure what's the best practice. Hmm, maybe we should add unstable_
prefix.
Size Change: +147 B (0%) Total Size: 156 kB
ℹ️ View Unchanged
|
(d) => listener({ d }), | ||
(e) => listener({ e }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this style is deprecated in rxjs. https://rxjs.dev/deprecations/subscribe-arguments
close #1404
error handling was already supported, so what this PR does are: