Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(devtools): silent useAtomsSnapshot/useGotoAtomsSnapshot in prod #1367

Merged
merged 9 commits into from
Aug 26, 2022

Conversation

Aslemammad
Copy link
Member

This PR tries to follow the footsteps of the useAtomsDevtools for useAtomsSnapshot/useGotoAtomsSnapshot!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vercel
Copy link

vercel bot commented Aug 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
jotai ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 6:39PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 24, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cd02a5a:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Aslemammad Aslemammad changed the title feat: deprecate scope option and add enabled option refactor: silent useAtomsSnapshot in prod Aug 25, 2022
@Aslemammad Aslemammad changed the title refactor: silent useAtomsSnapshot in prod refactor: silent useAtomsSnapshot/useGotoAtomsSnapshot in prod Aug 25, 2022
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dai-shi dai-shi added this to the v1.8.1 milestone Aug 25, 2022
@dai-shi dai-shi changed the title refactor: silent useAtomsSnapshot/useGotoAtomsSnapshot in prod refactor(devtools): silent useAtomsSnapshot/useGotoAtomsSnapshot in prod Aug 26, 2022
@dai-shi dai-shi merged commit b3a3ee2 into pmndrs:main Aug 26, 2022
@Aslemammad Aslemammad deleted the devtools-enable-option branch August 26, 2022 07:42
Aslemammad added a commit to Aslemammad/jotai that referenced this pull request Aug 26, 2022
…rod (pmndrs#1367)

* update

* update

* Revert "update"

This reverts commit 306a073.

* update

* update

* add DEV-ONLY to tess

* use store to see if __DEV__ is true

* remove optional chaining

* update docs

Co-authored-by: daishi <daishi@axlight.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants