Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): redesign invalidated flag #1296

Merged
merged 17 commits into from
Aug 8, 2022
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jul 21, 2022

close #1255

  • investigate the behavior
  • naive fix
  • refactor with "y" validity flag
  • fix useAtomsDevtools with "y"

Sorry, something went wrong.

@vercel
Copy link

vercel bot commented Jul 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
jotai ✅ Ready (Inspect) Visit Preview Aug 7, 2022 at 11:13PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c931b16:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

github-actions bot commented Jul 21, 2022

Size Change: +767 B (+1%)

Total Size: 145 kB

Filename Size Change
dist/devtools.js 3.93 kB +81 B (+2%)
dist/esm/devtools.js 3.03 kB +89 B (+3%)
dist/esm/index.js 5.13 kB +67 B (+1%)
dist/index.js 6.14 kB +66 B (+1%)
dist/system/devtools.development.js 3.22 kB +95 B (+3%)
dist/system/devtools.production.js 2.29 kB +56 B (+3%)
dist/system/index.development.js 5.35 kB +61 B (+1%)
dist/system/index.production.js 2.96 kB +18 B (+1%)
dist/umd/devtools.development.js 4.06 kB +80 B (+2%)
dist/umd/devtools.production.js 2.75 kB +65 B (+2%)
dist/umd/index.development.js 6.23 kB +59 B (+1%)
dist/umd/index.production.js 3.42 kB +30 B (+1%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 945 B
dist/babel/plugin-react-refresh.js 1.16 kB
dist/babel/preset.js 1.41 kB
dist/esm/babel/plugin-debug-label.js 801 B
dist/esm/babel/plugin-react-refresh.js 1 kB
dist/esm/babel/preset.js 1.25 kB
dist/esm/immer.js 643 B
dist/esm/optics.js 668 B
dist/esm/query.js 1.17 kB
dist/esm/redux.js 254 B
dist/esm/urql.js 1.33 kB
dist/esm/utils.js 4.94 kB
dist/esm/valtio.js 540 B
dist/esm/xstate.js 872 B
dist/esm/zustand.js 289 B
dist/immer.js 726 B
dist/optics.js 938 B
dist/query.js 1.27 kB
dist/redux.js 314 B
dist/system/babel/plugin-debug-label.development.js 911 B
dist/system/babel/plugin-debug-label.production.js 677 B
dist/system/babel/plugin-react-refresh.development.js 1.1 kB
dist/system/babel/plugin-react-refresh.production.js 863 B
dist/system/babel/preset.development.js 1.36 kB
dist/system/babel/preset.production.js 1.05 kB
dist/system/immer.development.js 772 B
dist/system/immer.production.js 469 B
dist/system/optics.development.js 770 B
dist/system/optics.production.js 455 B
dist/system/query.development.js 1.32 kB
dist/system/query.production.js 1.08 kB
dist/system/redux.development.js 344 B
dist/system/redux.production.js 217 B
dist/system/urql.development.js 1.49 kB
dist/system/urql.production.js 1.01 kB
dist/system/utils.development.js 5.28 kB
dist/system/utils.production.js 3.31 kB
dist/system/valtio.development.js 652 B
dist/system/valtio.production.js 400 B
dist/system/xstate.development.js 981 B
dist/system/xstate.production.js 626 B
dist/system/zustand.development.js 377 B
dist/system/zustand.production.js 235 B
dist/umd/babel/plugin-debug-label.development.js 1.11 kB
dist/umd/babel/plugin-debug-label.production.js 839 B
dist/umd/babel/plugin-react-refresh.development.js 1.31 kB
dist/umd/babel/plugin-react-refresh.production.js 994 B
dist/umd/babel/preset.development.js 1.56 kB
dist/umd/babel/preset.production.js 1.19 kB
dist/umd/immer.development.js 871 B
dist/umd/immer.production.js 570 B
dist/umd/optics.development.js 1.08 kB
dist/umd/optics.production.js 671 B
dist/umd/query.development.js 1.42 kB
dist/umd/query.production.js 1.1 kB
dist/umd/redux.development.js 454 B
dist/umd/redux.production.js 322 B
dist/umd/urql.development.js 1.77 kB
dist/umd/urql.production.js 1.22 kB
dist/umd/utils.development.js 9.65 kB
dist/umd/utils.production.js 6.22 kB
dist/umd/valtio.development.js 722 B
dist/umd/valtio.production.js 500 B
dist/umd/xstate.development.js 1.45 kB
dist/umd/xstate.production.js 912 B
dist/umd/zustand.development.js 479 B
dist/umd/zustand.production.js 334 B
dist/urql.js 1.62 kB
dist/utils.js 9.44 kB
dist/valtio.js 586 B
dist/xstate.js 1.31 kB
dist/zustand.js 344 B

compressed-size-action

@dai-shi dai-shi marked this pull request as ready for review July 21, 2022 13:45
@dai-shi dai-shi merged commit 380a277 into main Aug 8, 2022
@dai-shi dai-shi deleted the fix/core/revisit-invalidated-flag branch August 8, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] re-consider the use of invalidated flag
1 participant