docs(jotai/query): same query client initialisation #1294
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 91f042b:
|
austinwoon
changed the title
austinwoon
changed the title
docs/integrations/query.mdx
Outdated
|
|
||
| Although they reference methods same query keys (`'todos'`), should `useTodoMutation` be called and invalidate the query without the `Provider` initialisation step, `todosAtom` will not be prompted to refetch and will continue showing stale data. | ||
|
|
||
| ```js |
There was a problem hiding this comment.
I think it's helpful to have import statements in the code snippet.
| export const useTodoMutation = () => { | ||
| const queryClient = useQueryClient() | ||
|
|
||
| return useMutation( |
There was a problem hiding this comment.
useMutation is unavoidable at this point.
But, from the jotai/query perspective (which is not tied to React),
we would like to have atomWithMutation. (We have it in jotai/urql.)
Would you be interested in contributing in it?? Issue 👉 #309
There was a problem hiding this comment.
Thanks, would love to attempt and contribute to it.
Will try to implement a wrapper in my existing project and make a new PR when its ready!
Thanks for the quick review, great library! 🥳
I had a project with existing integrations with
react-querybefore importingjotaito the project.Upon using
atomWithQuerywithout this initialisation step, I realised that my existing functions which calledqueryClient.invalidate(...)did not result inatomWithQuery's query invalidating. As a result, data was not refetched and the atom had stale data.After browsing the discussions, I found the answer here #500 (reply in thread). The cause was because our functions were referencing different instances of
queryClientSeeing that this was a discussion thread, and that others might port in jotai into existing projects which already have
react-queryintegrated, I thought it might be helpful to add this piece of documentation into the official query integration documentation.Please let me know if the example and documentation is clear! Thank you.