Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): support error handling (full re-implementation) #1239

Merged
merged 30 commits into from
Jul 19, 2022

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jun 19, 2022

close #1199
close #1129

  • add failing tests for atomWithQuery
  • fix atomWithQuery
  • add failing tests for atomWithInfiniteQuery
  • fix atomWithInfiniteQuery
  • add codesandbox example in docs

Sorry, something went wrong.

@vercel
Copy link

vercel bot commented Jun 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
jotai ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 6:00AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 19, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d454fe:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

github-actions bot commented Jun 19, 2022

Size Change: +49 B (0%)

Total Size: 143 kB

Filename Size Change
dist/esm/index.js 4.95 kB +43 B (+1%)
dist/esm/query.js 1.01 kB -29 B (-3%)
dist/index.js 6.07 kB +40 B (+1%)
dist/query.js 1.29 kB -65 B (-5%)
dist/system/index.development.js 5.17 kB +43 B (+1%)
dist/system/index.production.js 2.94 kB +22 B (+1%)
dist/system/query.development.js 1.15 kB -32 B (-3%)
dist/system/query.production.js 831 B +1 B (0%)
dist/umd/index.development.js 6.17 kB +43 B (+1%)
dist/umd/index.production.js 3.38 kB +21 B (+1%)
dist/umd/query.development.js 1.44 kB -68 B (-5%)
dist/umd/query.production.js 1.06 kB +30 B (+3%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 945 B
dist/babel/plugin-react-refresh.js 1.16 kB
dist/babel/preset.js 1.41 kB
dist/devtools.js 3.85 kB
dist/esm/babel/plugin-debug-label.js 782 B
dist/esm/babel/plugin-react-refresh.js 996 B
dist/esm/babel/preset.js 1.23 kB
dist/esm/devtools.js 2.91 kB
dist/esm/immer.js 609 B
dist/esm/optics.js 661 B
dist/esm/redux.js 251 B
dist/esm/urql.js 1.26 kB
dist/esm/utils.js 4.83 kB
dist/esm/valtio.js 526 B
dist/esm/xstate.js 851 B
dist/esm/zustand.js 284 B
dist/immer.js 726 B
dist/optics.js 938 B
dist/redux.js 314 B
dist/system/babel/plugin-debug-label.development.js 889 B
dist/system/babel/plugin-debug-label.production.js 677 B
dist/system/babel/plugin-react-refresh.development.js 1.1 kB
dist/system/babel/plugin-react-refresh.production.js 863 B
dist/system/babel/preset.development.js 1.33 kB
dist/system/babel/preset.production.js 1.05 kB
dist/system/devtools.development.js 3.09 kB
dist/system/devtools.production.js 2.23 kB
dist/system/immer.development.js 733 B
dist/system/immer.production.js 469 B
dist/system/optics.development.js 765 B
dist/system/optics.production.js 455 B
dist/system/redux.development.js 339 B
dist/system/redux.production.js 217 B
dist/system/urql.development.js 1.41 kB
dist/system/urql.production.js 1.01 kB
dist/system/utils.development.js 5.17 kB
dist/system/utils.production.js 3.31 kB
dist/system/valtio.development.js 639 B
dist/system/valtio.production.js 400 B
dist/system/xstate.development.js 964 B
dist/system/xstate.production.js 626 B
dist/system/zustand.development.js 372 B
dist/system/zustand.production.js 235 B
dist/umd/babel/plugin-debug-label.development.js 1.11 kB
dist/umd/babel/plugin-debug-label.production.js 839 B
dist/umd/babel/plugin-react-refresh.development.js 1.31 kB
dist/umd/babel/plugin-react-refresh.production.js 994 B
dist/umd/babel/preset.development.js 1.56 kB
dist/umd/babel/preset.production.js 1.19 kB
dist/umd/devtools.development.js 3.98 kB
dist/umd/devtools.production.js 2.69 kB
dist/umd/immer.development.js 871 B
dist/umd/immer.production.js 570 B
dist/umd/optics.development.js 1.08 kB
dist/umd/optics.production.js 671 B
dist/umd/redux.development.js 454 B
dist/umd/redux.production.js 322 B
dist/umd/urql.development.js 1.77 kB
dist/umd/urql.production.js 1.22 kB
dist/umd/utils.development.js 9.65 kB
dist/umd/utils.production.js 6.22 kB
dist/umd/valtio.development.js 722 B
dist/umd/valtio.production.js 500 B
dist/umd/xstate.development.js 1.45 kB
dist/umd/xstate.production.js 912 B
dist/umd/zustand.development.js 479 B
dist/umd/zustand.production.js 334 B
dist/urql.js 1.62 kB
dist/utils.js 9.44 kB
dist/valtio.js 586 B
dist/xstate.js 1.31 kB
dist/zustand.js 344 B

compressed-size-action

@dai-shi dai-shi marked this pull request as ready for review July 19, 2022 04:35
@dai-shi dai-shi added this to the v1.7.6 milestone Jul 19, 2022
@dai-shi dai-shi changed the title fix(query): error handling fix(query): error handling (full re-implementation) Jul 19, 2022
@dai-shi dai-shi changed the title fix(query): error handling (full re-implementation) feat(query): error handling (full re-implementation) Jul 19, 2022
@dai-shi dai-shi changed the title feat(query): error handling (full re-implementation) feat(query): support error handling (full re-implementation) Jul 19, 2022
@dai-shi dai-shi merged commit 62a4550 into main Jul 19, 2022
@dai-shi dai-shi deleted the fix/query/error-handling branch July 19, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jotai with React Query, how to handle errors? [atomWithQuery] how to reset queryAtom when it throw error
1 participant