Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useAnimations): ensure API result updates with clips and root #1593

Merged
merged 4 commits into from
Aug 10, 2023
Merged

fix(useAnimations): ensure API result updates with clips and root #1593

merged 4 commits into from
Aug 10, 2023
+6 −3

Conversation

arcturus3
Copy link
Contributor

@arcturus3 arcturus3 commented Aug 1, 2023 •
edited
Loading

Why

Previously actualRef did not update if a new root argument was passed. Additionally, the clips, names, and actions of the API did not update if a new clips argument was passed.

Resolves #1481, resolves #1548.

What

Correctly update the API and ref in appropriate effects.

Checklist

  • Ready to be merged

Sorry, something went wrong.

@arcturus3
fix(useAnimations): ensure API result updates with clips and root
b9c3f4d 
Previously `actualRef` did not update if a new `root` argument was passed.
Additionally, the `clips`, `names`, and `actions` of the API
did not update if a new `clips` argument was passed.
@vercel
Copy link

vercel bot commented Aug 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 0:10am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 1, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bb79e3:

Sandbox Source
admiring-austin-2ck2gj Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@CodyJasonBennett CodyJasonBennett merged commit d91d980 into pmndrs:master Aug 10, 2023
@github-actions
Copy link

🎉 This PR is included in version 9.80.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@drcmda
Copy link
Member

drcmda commented Aug 20, 2023

@arcturus3 @CodyJasonBennett i had to revert, it broke uneAnimation for most boxes i've tried it with, for instance https://codesandbox.io/s/pecl6?file=/src/Model.js actions are null in useEffect for some reason. @arcturus3 could you look at it and find the problem? then we make a unified pull again with all changes included.

@arcturus3
Copy link
Contributor Author

arcturus3 commented Aug 20, 2023 •
edited
Loading

@drcmda Yep, I'll take a look at it tonight.

arcturus3 added a commit to arcturus3/drei that referenced this pull request Aug 21, 2023
@arcturus3
fix(useAnimations): ensure API result updates with clips and root (…
9e3e58c 
…pmndrs#1593)
@arcturus3 arcturus3 mentioned this pull request Aug 22, 2023
Merged
1 task
@arcturus3
Copy link
Contributor Author

@drcmda @CodyJasonBennett See #1620.

@ninjz ninjz mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodyJasonBennett CodyJasonBennett

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useAnimations does not update actions useAnimations is not updating on clip effects
3 participants
@arcturus3 @drcmda @CodyJasonBennett