Skip to content

Commit 4542e8d

Browse files
committedFeb 26, 2019
fixed typo in gl-mesh3d and edited mesh3d test
1 parent 012625d commit 4542e8d

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed
 

‎package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"gl-heatmap2d": "^1.0.5",
7979
"gl-line3d": "^1.1.10",
8080
"gl-mat4": "^1.2.0",
81-
"gl-mesh3d": "git://github.com/gl-vis/gl-mesh3d.git#31d34ba3cec063697cc3891e141532cd80d95ba3",
81+
"gl-mesh3d": "git://github.com/gl-vis/gl-mesh3d.git#4ae064574c882e1f3986e73059875208ebd93898",
8282
"gl-plot2d": "^1.4.2",
8383
"gl-plot3d": "git://github.com/gl-vis/gl-plot3d.git#3580a0eedd81b9f212186caa8e7018d8016274fe",
8484
"gl-pointcloud2d": "^1.0.2",

‎test/jasmine/tests/gl3d_plot_interact_test.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ describe('Test gl3d plots', function() {
387387
.then(done);
388388
});
389389

390-
it('@noCI @gl should display correct hover labels (mesh3d case)', function(done) {
390+
it('@gl should display correct hover labels (mesh3d case)', function(done) {
391391
var x = [1, 1, 2, 3, 4, 2];
392392
var y = [2, 1, 3, 4, 5, 3];
393393
var z = [3, 7, 4, 5, 3.5, 2];
@@ -417,19 +417,19 @@ describe('Test gl3d plots', function() {
417417
.then(delay(20))
418418
.then(_hover)
419419
.then(function() {
420-
assertHoverText('x: 3', 'y: 4', 'z: 5', 'ts: 3\nhz: 4\nftt:5');
420+
assertHoverText('x: 4', 'y: 5', 'z: 3.5', 'ts: 4\nhz: 5\nftt:3.5');
421421
})
422422
.then(function() {
423423
return Plotly.restyle(gd, 'hoverinfo', 'x+y');
424424
})
425425
.then(function() {
426-
assertHoverText('(3, 4)');
426+
assertHoverText('(4, 5)');
427427
})
428428
.then(function() {
429429
return Plotly.restyle(gd, 'hoverinfo', 'text');
430430
})
431431
.then(function() {
432-
assertHoverText('ts: 3\nhz: 4\nftt:5');
432+
assertHoverText('ts: 4\nhz: 5\nftt:3.5');
433433
})
434434
.then(function() {
435435
return Plotly.restyle(gd, 'text', 'yo!');
@@ -443,13 +443,13 @@ describe('Test gl3d plots', function() {
443443
]);
444444
})
445445
.then(function() {
446-
assertHoverText(null, null, null, 'ts: 3\nhz: 4\nftt:5 !!');
446+
assertHoverText(null, null, null, 'ts: 4\nhz: 5\nftt:3.5 !!');
447447
})
448448
.then(function() {
449449
return Plotly.restyle(gd, 'hovertemplate', '%{x}-%{y}-%{z}<extra></extra>');
450450
})
451451
.then(function() {
452-
assertHoverText(null, null, null, '3-4-5');
452+
assertHoverText(null, null, null, '4-5-3.5');
453453
})
454454
.catch(failTest)
455455
.then(done);

0 commit comments

Comments
 (0)
Please sign in to comment.