Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace extreme destination with async destination #1402

Merged
merged 4 commits into from
Apr 9, 2022

Conversation

mksmtn
Copy link
Contributor

@mksmtn mksmtn commented Apr 9, 2022

extreme destination does not exist on pino anymore

`extreme` destination does not exist on `pino` anymore
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just drop all that v4/v5 section. It's probably for the best, those are really old!

@mksmtn
Copy link
Contributor Author

mksmtn commented Apr 9, 2022

You mean like that?

@mksmtn mksmtn requested a review from mcollina April 9, 2022 18:24
@mcollina
Copy link
Member

mcollina commented Apr 9, 2022

You'd need to delete it from https://github.com/pinojs/pino/blob/master/docsify/sidebar.md and the README. Thanks!

mksmtn added 2 commits April 9, 2022 23:01
the section was about a very old version and better be deleted
the section was about a very old version and better be deleted
@mksmtn
Copy link
Contributor Author

mksmtn commented Apr 9, 2022

Oh, didn't read the notice "Sorry, forked repositories are not currently searchable." and just thought that nothing is found for "legacy" query. Fixed

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from jsumners April 9, 2022 19:31
@jsumners jsumners merged commit 26d8127 into pinojs:master Apr 9, 2022
@mksmtn mksmtn deleted the legacy-extreme-update branch April 9, 2022 22:31
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants