pass mkdir option on pino/file transport to destination #1223
+35
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojavelinux
force-pushed
the
issue-1221-pino-file-mkdir-option
branch
from
6c285cc to
bc93da6
Compare
mcollina
reviewed
Nov 16, 2021
|
Absolutely! Stay tuned.
|
mojavelinux
force-pushed
the
issue-1221-pino-file-mkdir-option
branch
from
bc93da6 to
5cd6127
Compare
kibertoad
reviewed
Nov 17, 2021
| @@ -4,7 +4,9 @@ const pino = require('./pino') | |||
| const { once } = require('events') | |||
|
|
|||
| module.exports = async function (opts = {}) { | |||
| const destination = pino.destination({ dest: opts.destination || 1, sync: false }) | |||
| const destOpts = { dest: opts.destination || 1, sync: false } | |||
| if (opts.mkdir) destOpts.mkdir = true | |||
There was a problem hiding this comment.
why not add ternary condition on destOpts instead?
There was a problem hiding this comment.
I'm happy to write it any way that's acceptable to the project. Adding an undefined property broke an existing test. I wrote it in such a way that the existing test would pass.
|
I've added a paragraph with an example to the transports.md docs as requested. Let me know if there's anything you'd like me to change. |
|
@mojavelinux could you send another PR with the |
|
Yep! On it. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
mkdiroption is specified on the pino/file transport, pass it to the pino.destination.closes #1221