Add ability to format time and level with user-defined prettifiers #263
+131
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Nov 14, 2021
jsumners
requested changes
Nov 14, 2021
Pull Request Test Coverage Report for Build 1458816767
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1467093039
💛 - Coveralls |
jsumners
reviewed
Nov 14, 2021
jsumners
reviewed
Nov 14, 2021
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
Co-authored-by: James Sumners <james@sumners.email>
jsumners
reviewed
Nov 15, 2021
Readme.md
Outdated
|
|
||
| Note that prettifiers do not include any coloring, if the stock coloring on `level` is desired, it can be accomplished using the following: | ||
| ```js | ||
| const levelColorize = require('pino-pretty/lib/colors.js')(true) |
There was a problem hiding this comment.
I do not want to promote relying on an internal API like this. If we are going to support this, we should expose the colorizer as a property of the main export, e.g. const { colorizerFactory } = require('pino-pretty').
mcollina
requested changes
Nov 15, 2021
|
No problem! |
jsumners
reviewed
Nov 15, 2021
Co-authored-by: James Sumners <james@sumners.email>
jsumners
approved these changes
Nov 16, 2021
mcollina
reviewed
Nov 16, 2021
| @@ -214,4 +214,5 @@ function build (opts = {}) { | |||
|
|
|||
| module.exports = build | |||
| module.exports.prettyFactory = prettyFactory | |||
| module.exports.colorizerFactory = colors | |||
There was a problem hiding this comment.
Could you add a test to cover this new public API?
There was a problem hiding this comment.
Sure - I've expanded the colorizer test to ensure both exports behave the same! If there's something else you had in mind please let me know. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would close issues like #185, and put more formatting capabilities into userland.
If another option-key besides
customPrettifiersshould be used I'm happy to switch. I think the docs are a bit open to interpretation even though I see this option is only being used to prettify object-formatting right now.