Support SonicBoom as a destination #256
Merged
+78
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Nov 1, 2021
Readme.md
Outdated
| @@ -207,6 +207,11 @@ The options accepted have keys corresponding to the options described in [CLI Ar | |||
| ignore: 'pid,hostname', // --ignore | |||
| hideObject: false, // --hideObject | |||
| singleLine: false, // --singleLine | |||
|
|
|||
| dest: 1, // The file or file descriptor to write to | |||
| append: true, // Append to the destination | |||
There was a problem hiding this comment.
What happens if it is false? Will it overwrite the destination?
kibertoad
reviewed
Nov 1, 2021
Readme.md
Outdated
|
|
||
| dest: 1, // The file or file descriptor to write to | ||
| append: true, // Append to the destination | ||
| mkdir: false, // Ensure the directory for dest exist when true |
There was a problem hiding this comment.
Does this work recursively?
kibertoad
reviewed
Nov 1, 2021
Readme.md
Outdated
| @@ -207,6 +207,11 @@ The options accepted have keys corresponding to the options described in [CLI Ar | |||
| ignore: 'pid,hostname', // --ignore | |||
| hideObject: false, // --hideObject | |||
| singleLine: false, // --singleLine | |||
|
|
|||
| dest: 1, // The file or file descriptor to write to | |||
There was a problem hiding this comment.
what does default destination of 1 mean?
There was a problem hiding this comment.
the file descriptor of stdout.
kibertoad
reviewed
Nov 1, 2021
jsumners
requested changes
Nov 2, 2021
|
I've updated it, let me know what you think |
kibertoad
approved these changes
Nov 3, 2021
mcollina
changed the title
Co-authored-by: James Sumners <james@sumners.email>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a couple of missing options