chore: documentation and CI updates #183
Conversation
Pull Request Test Coverage Report for Build 817490292
💛 - Coveralls |
|
@mcollina, mind if i open similar requests on other pino repos? |
|
go for it! |
| "ci": "standard && tap \"test/**/*.test.js\" --coverage-report=lcovonly", | ||
| "lint": "standard | snazzy", | ||
| "test": "tap --100 'test/**/*.test.js'" | ||
| "test": "tap --100 \"test/**/*.test.js\"" |
There was a problem hiding this comment.
These changes should not have been made. The " will introduce shell expansion of **/*.test.js. The ' prevents shell expansion and allows the glob package to do the expansion.
@Fdawgs please do not blanket change quotes.
There was a problem hiding this comment.
Ah, sorry @jsumners. Is there a better way of doing this?
The Fastify repos all use a similar method to ensure the tests run on Windows.
There was a problem hiding this comment.
They should all be using single quotes.
There was a problem hiding this comment.
After further investigation, I don't think it matters if single or double quotes are used when it's just globbing (phew, no mass opening of PRs on all of Fastify's repos):
$ cd test
$ echo *
decorate.test.js hook.test.js integration.test.js plugin.test-d.ts
$ echo "*"
*
$ echo '*'
*
No description provided.