allow sonic-boom to filter call to close on stdout (#280)

Author: mojavelinux

index.js

@@ -196,13 +196,6 @@ function build (opts = {}) {
         sync: false
       })
     }
-    /* istanbul ignore else */
-    if (destination.fd === 1) {
-      // We cannot close the output
-      destination.end = function () {
-        this.emit('close')
-      }
-    }
 
     source.on('unknown', function (line) {
       destination.write(line + '\n')

test/basic.test.js

@@ -848,6 +848,32 @@ test('basic prettifier tests', (t) => {
     t.doesNotThrow(pinoPretty)
   })
 
+  t.test('does not call fs.close on stdout stream', (t) => {
+    t.plan(2)
+    const destination = pino.destination({ minLength: 4096, sync: true })
+    const prettyDestination = pinoPretty({ destination, colorize: false })
+    const log = pino(prettyDestination)
+    log.info('this message has been buffered')
+    const chunks = []
+    const { close, writeSync } = fs
+    let closeCalled = false
+    fs.close = new Proxy(close, {
+      apply: (target, self, args) => {
+        closeCalled = true
+      }
+    })
+    fs.writeSync = new Proxy(writeSync, {
+      apply: (target, self, args) => {
+        chunks.push(args[1])
+        return args[1].length
+      }
+    })
+    destination.end()
+    Object.assign(fs, { close, writeSync })
+    t.match(chunks.join(''), /INFO .+: this message has been buffered/)
+    t.equal(closeCalled, false)
+  })
+
   t.test('stream usage', async (t) => {
     t.plan(1)
     const tmpDir = path.join(__dirname, '.tmp_' + Date.now())