Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: panva/node-oidc-provider
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 94dfcf4d3da7490470d1913d4cb516c0d6c01e53
Choose a base ref
...
head repository: panva/node-oidc-provider
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 55f4fb7685359296d974397cef0d35c82c8ae18a
Choose a head ref

Commits on Oct 30, 2019

  1. refactor: use invalid_redirect_uri over redirect_uri_mismatch error

    BREAKING CHANGE: RedirectUriMismatch error was removed.
    
    BREAKING CHANGE: `redirect_uri_mismatch` error codes are now
    `invalid_redirect_uri`.
    panva committed Oct 30, 2019
    Copy the full SHA
    2565cce View commit details

Commits on Mar 3, 2020

  1. feat: require Node.js version ^12.19.0 || ^14.15.0

    BREAKING CHANGE: Node.js runtime version policy changed. Version
    12.19.0 is now the minimum required runtime and *ONLY LTS* releases are
    supported. This means "Current" Node releases are not officially
    supported and you may get mixed results when using them.
    panva committed Mar 3, 2020
    Copy the full SHA
    2a54e33 View commit details
  2. refactor: provider.callback is now a function instead of a getter

    BREAKING CHANGE: `Provider.prototype.callback` is now a function instead
    of a getter.
    panva committed Mar 3, 2020
    Copy the full SHA
    e78e573 View commit details
  3. refactor: provider.interactionDetails(req, res) now requires res

    BREAKING CHANGE: `provider.interactionDetails` now only works if both
    `req` and `res` are provided.
    panva committed Mar 3, 2020
    Copy the full SHA
    2c3a667 View commit details
  4. refactor: OIDCContext and Interaction property signed renamed

    BREAKING CHANGE: `OIDCContext` and `Interaction` instance property
    `signed` renamed to `trusted`.
    panva committed Mar 3, 2020
    Copy the full SHA
    0ed56bd View commit details
  5. refactor: introspection response jti not returned for opaque tokens

    BREAKING CHANGE: Introspection response `jti` is not returned for
    opaque tokens.
    panva committed Mar 3, 2020
    Copy the full SHA
    a333aaa View commit details
  6. refactor: audience arrays with 1 member are changed to a single value

    BREAKING CHANGE: Single member audience arrays are now transformed to a
    single audience string value instead.
    panva committed Mar 3, 2020
    Copy the full SHA
    d156983 View commit details
  7. Copy the full SHA
    16d26db View commit details
  8. refactor: extraClientMetadata.validator arguments reordered

    BREAKING CHANGE: `extraClientMetadata.validator` `ctx` argument is now
    the first one.
    panva committed Mar 3, 2020
    Copy the full SHA
    ea6dc73 View commit details
  9. refactor: require client in structured tokens constructors

    BREAKING CHANGE: Structured token constructors now require a client
    property with a client instance rather than a clientId property.
    panva committed Mar 3, 2020
    Copy the full SHA
    a4e02bd View commit details

Commits on Mar 6, 2020

  1. refactor: removed provider.setInteractionSession and result meta object

    BREAKING CHANGE: `provider.setInteractionSession` function was removed.
    
    BREAKING CHANGE: `meta` interaction result was removed.
    panva committed Mar 6, 2020
    Copy the full SHA
    ac1b0f6 View commit details
  2. Copy the full SHA
    3076f32 View commit details
  3. Copy the full SHA
    3949f7f View commit details
  4. Copy the full SHA
    43b8ebe View commit details
  5. refactor: updated got http request library

    BREAKING CHANGE: httpOptions helper function argument is now just
    a URL instance. It no longer receives the "to be executed" http request
    options.
    
    BREAKING CHANGE: httpOptions helper changed. It can now only return
    three properties {
      `timeout`: number,
      `agent`: instanceof https.Agent || http.Agent,
      `lookup`: dns.lookup like option
    }
    panva committed Mar 6, 2020
    Copy the full SHA
    b395a0d View commit details
  6. refactor: removed dynamicScopes configuration option

    BREAKING CHANGE: removed `dynamicScopes` configuration option, scope
    configuration using pre-configured values is gone in favour of
    Resource Indicators refactor.
    panva committed Mar 6, 2020
    Copy the full SHA
    285fc7a View commit details
  7. Copy the full SHA
    f6e2d03 View commit details
  8. Copy the full SHA
    d045a8a View commit details

Commits on Mar 10, 2020

  1. refactor: remove the deprecated OIDCContext.prototype.bearer method

    BREAKING CHANGE: The deprecated `OIDCContext.prototype.bearer` method
    is removed.
    panva committed Mar 10, 2020
    Copy the full SHA
    52000d5 View commit details

Commits on Mar 11, 2020

  1. refactor: remove deprecated setS256Thumbprint token instance method

    BREAKING CHANGE: The deprecated `setS256Thumbprint` token instance
    method is removed.
    panva committed Mar 11, 2020
    Copy the full SHA
    6afaf31 View commit details
  2. Copy the full SHA
    4df1a0c View commit details

Commits on Mar 17, 2020

  1. refactor: default clientBasedCORS helper is now false

    BREAKING CHANGE: Default clientBasedCORS helper return value is now
    `false`, you must ergo use this helper to open up cors based on your
    policy.
    panva committed Mar 17, 2020
    Copy the full SHA
    4cf4cc6 View commit details

Commits on Mar 18, 2020

  1. refactor: removed a bunch of proxied methods from provider to app

    BREAKING CHANGE: The following Provider instance getters/setters are
    removed: subdomainOffset, proxyIpHeader, maxIpsCount, keys. You can
    access the underlying Koa app via `provider.app` if you have the need
    to use these.
    panva committed Mar 18, 2020
    Copy the full SHA
    3fb32e7 View commit details

Commits on Mar 19, 2020

  1. refactor: default Interaction TTL increased from 10 minutes to 1 hour

    BREAKING CHANGE: Default Interaction TTL increased from 10 minutes to
    1 hour.
    panva committed Mar 19, 2020
    Copy the full SHA
    f6c7b5e View commit details
  2. docs: update clockTolerance doc

    panva committed Mar 19, 2020
    Copy the full SHA
    4cb0b8f View commit details

Commits on Mar 25, 2020

  1. refactor: provider's jwks_uri is now application/jwk-set+json content

    BREAKING CHANGE: The jwks_uri response is now using the proper content
    type `application/jwk-set+json`.
    panva committed Mar 25, 2020
    Copy the full SHA
    285eb41 View commit details

Commits on Apr 1, 2020

  1. Copy the full SHA
    422044c View commit details
  2. Copy the full SHA
    e959b7e View commit details
  3. refactor: renamed extraAccessTokenClaims helper function

    BREAKING CHANGE: `extraAccessTokenClaims` helper function is renamed to
    `extraTokenClaims`.
    panva committed Apr 1, 2020
    Copy the full SHA
    ce57d6d View commit details

Commits on Apr 27, 2020

  1. fix: only www-urlencoded bodies recognize RFC6750 payload bearer token

    BREAKING CHANGE: Only www-urlencoded bodies recognize RFC6750 payload
    bearer token. On the authorization server this only affects the dynamic
    registration features and removes an unintended side effect.
    panva committed Apr 27, 2020
    Copy the full SHA
    4553bd5 View commit details

Commits on May 14, 2020

  1. refactor: remove deprecated pkceMethods configuration property

    BREAKING CHANGE: The deprecated `pkceMethods` configuration property was
    removed, use `pkce.methods` instead.
    panva committed May 14, 2020
    Copy the full SHA
    65712d0 View commit details

Commits on May 19, 2020

  1. Copy the full SHA
    1abee64 View commit details
  2. Copy the full SHA
    3c55109 View commit details
  3. Copy the full SHA
    56b62cc View commit details

Commits on Jul 14, 2020

  1. docs: update docs for v7.x

    panva committed Jul 14, 2020
    Copy the full SHA
    8f10e56 View commit details

Commits on Aug 14, 2020

  1. refactor: remove few deprecated configuration properties

    BREAKING CHANGE: The deprecated `postLogoutSuccessSource` configuration
    property was removed, use
    `features.rpInitiatedLogout.postLogoutSuccessSource` instead.
    
    BREAKING CHANGE: The deprecated `logoutSource` configuration
    property was removed, use
    `features.rpInitiatedLogout.logoutSource` instead.
    panva committed Aug 14, 2020
    Copy the full SHA
    1767c8f View commit details
  2. refactor: request_object_signing_alg no longer forces request object use

    BREAKING CHANGE: `request_object_signing_alg` no longer means a request
    object must be provided, `require_signed_request_object` boolean value
    serves that purpose now as per the clarifications made in OIDF and IETF
    Working Groups.
    panva committed Aug 14, 2020
    Copy the full SHA
    e7309af View commit details
  3. refactor: only allow objects as claims configuration parameter

    BREAKING CHANGE: The `claims` configuration property can no longer be
    a `Map` instance, only plain objects are allowed.
    panva committed Aug 14, 2020
    Copy the full SHA
    2ac59b7 View commit details

Commits on Aug 20, 2020

  1. chore: update todo

    panva committed Aug 20, 2020
    Copy the full SHA
    9b60266 View commit details

Commits on Sep 2, 2020

  1. refactor: clean up RequestUriCache

    BREAKING CHANGE: Removed built in support for urn: request uris.
    BREAKING CHANGE: Renamed RequestUriCache.prototype.resolveWebUri to
    RequestUriCache.prototype.resolve
    panva committed Sep 2, 2020
    Copy the full SHA
    8c0b9c5 View commit details

Commits on Sep 3, 2020

  1. refactor: changed default signing algorithm selection method

    BREAKING CHANGE: The default for JWT Access Tokens' signing algorithm
    is no longer the client's `id_token_signed_response_alg` falling back to
    RS256 but rather only the provider's default
    `id_token_signed_response_alg`.
    panva committed Sep 3, 2020
    Copy the full SHA
    995d2d4 View commit details
  2. feat: opaque token length can now be influenced

    This adds a new `formats.bitsOfOpaqueRandomness` configuration option.
    It can be a number or a function returning an integer that tells the
    provider the minimum randomness in bits.
    
    resolves #760
    panva committed Sep 3, 2020
    Copy the full SHA
    f35764f View commit details

Commits on Sep 9, 2020

  1. chore: update deps

    panva committed Sep 9, 2020
    Copy the full SHA
    32b0478 View commit details

Commits on Sep 11, 2020

  1. Copy the full SHA
    4cc28ef View commit details
  2. refactor: default enabled JWAs

    This removes HS256 as a default-enabled value from the following
    configuration values so that all AS-issued assertions are
    firm to only come from the AS
    
    - whitelistedJWA.idTokenSigningAlgValues
    - whitelistedJWA.userinfoSigningAlgValues
    - whitelistedJWA.introspectionSigningAlgValues
    - whitelistedJWA.authorizationSigningAlgValues
    
    This also revises the default JWE algorithms
    
    BREAKING CHANGE: Removed HS256 as a default-enabled algorithm from the
    following configuration values so that all AS-issued assertions are
    firm to only come from the AS: `whitelistedJWA.idTokenSigningAlgValues`,
    `whitelistedJWA.userinfoSigningAlgValues`,
    `whitelistedJWA.introspectionSigningAlgValues`,
    `whitelistedJWA.authorizationSigningAlgValues`
    
    BREAKING CHANGE: Default JWE Algorithms ("alg") now includes "dir".
    
    BREAKING CHANGE: ECDH-ES KW variants are not enabled by default anymore.
    panva committed Sep 11, 2020
    Copy the full SHA
    d8ebde0 View commit details
  3. refactor: configuration whitelistedJWA is now enabledJWA

    BREAKING CHANGE: Configuration option `whitelistedJWA` is now
    `enabledJWA`.
    panva committed Sep 11, 2020
    Copy the full SHA
    d77fd4f View commit details

Commits on Oct 19, 2020

  1. refactor: requestObjects.mergingStrategy "whitelist" was removed

    BREAKING CHANGE: Removed "whitelist" Request Object merging strategy
    BREAKING CHANGE: `requestObjects.mergingStrategy` configuration is now a
    string valued "strict" or "lax"
    BREAKING CHANGE: `requestObjects.mergingStrategy` configuration is now
    `requestObjects.mode`.
    panva committed Oct 19, 2020
    Copy the full SHA
    7b10e9f View commit details
  2. refactor: by default disabled JWT Userinfo Responses

    BREAKING CHANGE: `features.jwtUserinfo` is disabled by default now.
    panva committed Oct 19, 2020
    Copy the full SHA
    5931a59 View commit details

Commits on Oct 24, 2020

  1. Copy the full SHA
    3df6e50 View commit details

Commits on Nov 30, 2020

  1. refactor: replaced lru-cache with quick-lru

    Request URI Cache no longer expires based on the
    response cache headers.
    panva committed Nov 30, 2020
    Copy the full SHA
    32b728b View commit details
Showing 494 changed files with 27,554 additions and 21,142 deletions.
32 changes: 30 additions & 2 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -2,7 +2,35 @@
"extends": "airbnb-base",
"rules": {
"no-empty": ["error", { "allowEmptyCatch": true }],
"no-underscore-dangle": ["error", { "allow": ["_claim_names", "_claim_sources", "_matchedRouteName"] }],
"import/order": ["error", { "groups": ["builtin", "external", "internal", "parent", "sibling", "index"], "newlines-between": "always" }]
"no-underscore-dangle": ["error", { "allow": ["_claim_names", "_claim_sources", "_matchedRouteName", "__dirname"] }],
"import/order": ["error", { "groups": ["builtin", "external", "internal", "parent", "sibling", "index"], "newlines-between": "always" }],
"symbol-description": ["off"],
"import/extensions": ["error", "ignorePackages"],
"no-restricted-syntax": [
"error",
{
"selector": "LabeledStatement",
"message": "Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand."
},
{
"selector": "WithStatement",
"message": "`with` is disallowed in strict mode because it makes code impossible to predict and optimize."
}
],
"max-len": [
"error",
100,
2,
{
"ignoreUrls": true,
"ignoreComments": true,
"ignoreRegExpLiterals": true,
"ignoreStrings": true,
"ignoreTemplateLiterals": true
}
]
},
"parserOptions": {
"ecmaVersion": "latest"
}
}
45 changes: 0 additions & 45 deletions .github/ISSUE_TEMPLATE/bug-report.md

This file was deleted.

46 changes: 46 additions & 0 deletions .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name: 🐞Bug report
description: There's a bug I want to report
labels: triage
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report. Do not use this form to ask questions, make suggestions or report something you're not sure is a bug, use the [appropriate](https://github.com/panva/node-oidc-provider/issues/new/choose) Discussions Topic for those.
- type: textarea
attributes:
label: What happened?
description: A clear and concise description of what the bug is and what you expected to happen instead.
validations:
required: true
- type: input
attributes:
label: Version
description: What exact version of the library do you use?
placeholder: e.g. v7.3.0
validations:
required: true
- type: input
attributes:
label: Node.js version
description: What exact version of node.js do you use?
placeholder: e.g. v14.17.3
validations:
required: true
- type: textarea
attributes:
label: Reproduction & Logs
description: Please create a gist or a public repo which can be cloned, installed and ran locally. Provide the link here as well as any additional steps to reproduce or useful logs.
validations:
required: true
- type: checkboxes
attributes:
label: Required
options:
- label: I have provided a gist or a public repo which can be cloned, installed and ran locally in order to reproduce the bug in the textarea above.
required: true
- label: I have searched the issues tracker and discussions for similar topics and couldn't find anything related.
required: true
- label: I have searched the [FAQ](https://github.com/panva/node-oidc-provider/blob/v8.x/docs/README.md#faq) and couldn't find anything related.
required: true
- label: I agree to follow this project's [Code of Conduct](https://github.com/panva/node-oidc-provider/blob/main/CODE_OF_CONDUCT.md)
required: true
17 changes: 5 additions & 12 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,14 @@
blank_issues_enabled: false
contact_links:
- name: Support the project
url: https://github.com/sponsors/panva
about:
To make sure you get your questions answered
- name: ❓ Question
url: https://github.com/panva/node-oidc-provider/discussions/894
about:
Have a question about using oidc-provider? Head over to the discussions "Q&A" Category
Have a question about using oidc-provider? Support the project and then head over to the discussions "Q&A" Category
- name: 💡 Feature proposal
url: https://github.com/panva/node-oidc-provider/discussions/893
about:
Have a proposal for a new feature? Head over to the discussions "Ideas" Category
- name: Support the project
url: https://github.com/sponsors/panva
about:
Are you asking your nth question? Relying on oidc-provider for critical operations? Consider
supporting the project so that it may continue being maintained.
- name: Report a security vulnerability
url: https://en.wikipedia.org/wiki/Responsible_disclosure
about:
Do not disclose vulnerabilities via issues or discussions. Reach out to the project team
via e.g. email, we'll work together on patching the vulnerability and follow some form of
Responsible disclosure once fixed. Thank you.
12 changes: 12 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# To get started with Dependabot version updates, you'll need to specify which
# package ecosystems to update and where the package manifests are located.
# Please see the documentation for all configuration options:
# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates

version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
# Check for updates to GitHub Actions every week
interval: "weekly"
55 changes: 0 additions & 55 deletions .github/workflows/codeql-analysis.yml

This file was deleted.

75 changes: 75 additions & 0 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
# For most projects, this workflow file will not need changing; you simply need
# to commit it to your repository.
#
# You may wish to alter this file to override the set of languages analyzed,
# or to provide custom queries or build logic.
#
# ******** NOTE ********
# We have attempted to detect the languages in your repository. Please check
# the `language` matrix defined below to confirm you have the correct set of
# supported CodeQL languages.
#
name: "CodeQL"

on:
push:
branches: [ "main" ]
pull_request:
# The branches below must be a subset of the branches above
branches: [ "main" ]
schedule:
- cron: '55 11 * * 1'

jobs:
analyze:
if: ${{ github.repository == 'panva/node-oidc-provider' }}
name: Analyze
runs-on: ubuntu-latest
permissions:
actions: read
contents: read
security-events: write

strategy:
fail-fast: false
matrix:
language: [ 'javascript' ]
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
# Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support

steps:
- name: Checkout repository
uses: actions/checkout@v4

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.

# Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
# queries: security-extended,security-and-quality


# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v2

# ℹ️ Command-line programs to run using the OS shell.
# 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun

# If the Autobuild fails above, remove it and uncomment the following three lines.
# modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.

# - run: |
# echo "Run, Build Application using script"
# ./location_of_script_within_repo/buildscript.sh

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
with:
category: "/language:${{matrix.language}}"
Loading