Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed typescript compilation issue introduced by 4.9.0 #733

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

zashraf1985
Copy link
Contributor

@zashraf1985 zashraf1985 commented Jan 18, 2022

Summary

4.9.0 introduced a typescript compilation issue due to an unused import. This PR fixes that.

Test plan

All unit, cross browser and full stack compatibility tests pass.

Issues

"Fixes #732"

@zashraf1985 zashraf1985 requested a review from a team as a code owner January 18, 2022 19:24
@zashraf1985 zashraf1985 removed their assignment Jan 18, 2022
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@The-inside-man The-inside-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.184% when pulling 60da91f on zeeshan/fix-issue-732 into 2e0623c on master.

@zashraf1985 zashraf1985 merged commit e98872d into master Jan 18, 2022
@zashraf1985 zashraf1985 deleted the zeeshan/fix-issue-732 branch January 18, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type Error on 4.9.0
4 participants